solr SOLR-15561: Write escaped strings in JsonTextWriter to a StringBuilder before the writer.

https://issues.apache.org/jira/browse/SOLR-15561

Nov 03 '21 11:11 markrmiller

This seems like a reasonable change. I merged main to this branch and PR is ready to review.

Oct 15 '22 21:10 risdenk

I dunno... if a benchmark shows its faster then cool but I think it's dubious -- probably a needless level of buffering on something that likely already has a buffer.

Oct 15 '22 21:10 dsmiley

@markrmiller did you find this when profiling something?

Oct 17 '22 15:10 HoustonPutman

Yeah, Yonik has some really heavy json faceting tests that are easy to look at. Some rare honest tests - far from quick, doing a lot of legitimate work, not bogarting the hardware. One of a small set of tests that really demand a useable @Nightly test run. No fat, thorough and comprehensive. An example of tests that should legitimately kick off work to sensible @Nightly vs the ones that do so as a workaround.

Oct 17 '22 16:10 markrmiller

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution!

Feb 23 '24 00:02 github-actions[bot]