solr icon indicating copy to clipboard operation
solr copied to clipboard
verified publisher icon apache

GHA renovation

Open dsmiley opened this issue 6 months ago • 1 comments

  • branches (all)
  • timeout-minutes
  • checkout version
  • harmonization across scripts (spacing / wording / labels)
  • remove chmod for gradlew (unnecessary)

Caching tweaks: removed this but I'm unsure: https://github.com/apache/lucene-solr/pull/1910 CC @madrob

dsmiley avatar Jun 19 '25 16:06 dsmiley

The elaborate caching configuration is not in Lucene, despite that same elaborate caching configuration being committed before the lucene-solr split. Thus Lucene devs removed it. In particular, it was @dweiss in apache/lucene#13110

I'm going to further improve this PR to use the nice .github/actions/prepare-for-build/action.yml (in Lucene, small tweaks for Solr) refactoring so that each GHA can share it

dsmiley avatar Jun 19 '25 16:06 dsmiley

@madrob when you first added that 5 years ago, we weren't using the GHA gradle action or it didn't exist then. It now does with caching built-in. My goal here is to simplify.

dsmiley avatar Jun 28 '25 02:06 dsmiley

The docker build isn't taking any noticeably longer here than the test runs I see in the GHA dashboard for that script. I want to merge this Tuesday evening.

dsmiley avatar Jul 27 '25 19:07 dsmiley