solr icon indicating copy to clipboard operation
solr copied to clipboard
verified publisher icon apache

SOLR-17746: Rollback extra argument verification for bin/solr start --jettyconfig option

Open epugh opened this issue 8 months ago • 1 comments

https://issues.apache.org/jira/browse/SOLR-17746

Description

Removing extra argument check that defaults passing in an argument! Add a test, and update some docs.

Tests

Bats test

Checklist

Please review the following and check all that apply:

  • [x ] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • [ x] I have created a Jira issue and added the issue ID to my pull request title.
  • [ x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • [x ] I have developed this patch against the main branch.
  • [ x] I have run ./gradlew check.
  • [ x] I have added tests for my changes.
  • [x ] I have added documentation for the Reference Guide

epugh avatar Apr 19 '25 13:04 epugh

@rahulgoswami could I ask you to give a quick looksee at this change since it impacts Windows?

epugh avatar Jun 13 '25 17:06 epugh

Sorry I have not been able to get to this. Wil give this a spin tonight

rahulgoswami avatar Jun 24 '25 15:06 rahulgoswami

Sorry I have not been able to get to this. Wil give this a spin tonight

thanks!

epugh avatar Jun 24 '25 15:06 epugh

Tried 'solr start --jettyconfig "--module=server"' on Windows and it starts fine. The Solr admin page opens fine. Although I feel I should see the "--module" option in the Args list under Dashboard, which I don't. So don't have an evidence of this reflecting. Please correct me if I am wrong.

rahulgoswami avatar Jun 25 '25 15:06 rahulgoswami

Tried 'solr start --jettyconfig "--module=server"' on Windows and it starts fine. The Solr admin page opens fine. Although I feel I should see the "--module" option in the Args list under Dashboard, which I don't. So don't have an evidence of this reflecting. Please correct me if I am wrong.

Maybe! That though feels like potentially another issue.... I'm going to go with a "this works".

epugh avatar Jun 25 '25 15:06 epugh

Maybe! That though feels like potentially another issue.... I'm going to go with a "this works".

Are we sticking with the "${2:0:1}" == "-" check on Linux ? I haven't tried running this on Mac.

rahulgoswami avatar Jun 25 '25 15:06 rahulgoswami