apache
SmokeTestRelease Added support for multiple JDK
This PR removes the hardcoded reference to Java and introduces support for multiple JDK versions through the new --test-alt-java parameter. This enhancement was largely inspired by the work in Apache Lucene PR #13108.
Credits to the contributors of the original implementation for their valuable insights.
Though I have yet to test with the different version. I mostly ran it with the same version, and on mac.
python3 -u ./dev-tools/scripts/smokeTestRelease.py --test-alt-java /Library/Java/JavaVirtualMachines/jdk-21.jdk/Contents/Home file:///tmp/releases/10.0.0/solr-10.0.0-RC1-rev-fed9db04b5b16ae829d9c7bfb19b972ade0f0bdc
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again.
@iamsanjay Can you also update the description of the tool in README.md in the scripts folder?
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution!
@iamsanjay I merged in main branch and resolved conflicts the best I could. I also updated README.md with the latest usage text for the tool, and took it for a spin and fixed a bug with an uninitialized variable.
However, I don't have a release candidate at hand for testing with.
@HoustonPutman are you willing to be the first to test this generalization for the 9.8.1 release? It basically lets you test with one or more alternative JDKs instead of hardcoded versions as in todays script. So you could
dev-tools/scripts/smokeTestRelease.py --revision 9.8.1 --test-alt-java /path/to/java23 --test-alt-java /path/to/java25 ...
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution!
No response on my latest changes, so I'll assume lazy consensus and merge this as is.