apache
remove deprecated (DocValues,Norms)FieldExistsQuery use
for main and branch_9x only, no JIRA or solr/CHANGES.txt entry needed in my opinion.
As there is now FieldExistsQuery covering a range of cases (not just even docValues & norms), this probably obsoletes complexity inside FieldType.getExistenceQuery. Can we just call that and remove getSpecializedExistenceQuery as needless in lieu of subtypes overriding getExistenceQuery?
CC @HoustonPutman as you worked on this method
Personally I don't have bandwidth to pursue this, but perhaps others do, "allow edits by maintainers" is enabled for the PR i.e. feel free to push commits to the branch.
And/Or could getSpecializedExistenceQuery removal be done separately after this pull request?
Added @chatman and @noblepaul w.r.t. overlap with the #3053 upgrade to Lucene 10.
As there is now FieldExistsQuery covering a range of cases (not just even docValues & norms), this probably obsoletes complexity inside FieldType.getExistenceQuery. Can we just call that and remove getSpecializedExistenceQuery as needless in lieu of subtypes overriding getExistenceQuery?
CC @HoustonPutman as you worked on this method
It looks like the range of cases are just docValues, norms and vectors. Not sure we can get rid of much of the complexity. getSpecializedExistenceQuery is still necessary for double/float fields without docValues or norms. and Spatial fields. I think this just moves the three query classes into one class.
for
mainandbranch_9xonly, no JIRA or solr/CHANGES.txt entry needed in my opinion.
Suggest main branch only, since now changes for https://issues.apache.org/jira/browse/SOLR-14199 are also included, WDYT?
Suggest
mainbranch only, since now changes for https://issues.apache.org/jira/browse/SOLR-14199 are also included, WDYT?
So that Jira isn't actually done here. Inside Solr is removing norms on the field, but it's not giving users an error when it's defined. So it should be back-compat... Let's see that the tests pass with this though.
Ok I've undone the pointField stuff, as the only clean way is to throw an error to users. So let's do https://issues.apache.org/jira/browse/SOLR-14199 completely separately.
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution!
This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again.
Just noting retrospectively that my intention here had been to (slightly) reduce the scope of the #3053 changes (and for branch_9x to get the changes in this PR too) but then it sort of dropped off the radar somehow, sorry. Now no-longer-applicable since PR 3053 is merged.