solr icon indicating copy to clipboard operation
solr copied to clipboard

Update org.apache.logging.log4j:* to v2.24.1

Open solrbot opened this issue 2 years ago • 6 comments

This PR contains the following updates:

Package Type Update Change
org.apache.logging.log4j:log4j-web (source) dependencies minor 2.21.0 -> 2.24.1
org.apache.logging.log4j:log4j-slf4j2-impl (source) dependencies minor 2.21.0 -> 2.24.1
org.apache.logging.log4j:log4j-layout-template-json (source) dependencies minor 2.21.0 -> 2.24.1
org.apache.logging.log4j:log4j-jul (source) dependencies minor 2.21.0 -> 2.24.1
org.apache.logging.log4j:log4j-core (source) dependencies minor 2.21.0 -> 2.24.1
org.apache.logging.log4j:log4j-api (source) dependencies minor 2.21.0 -> 2.24.1
org.apache.logging.log4j:log4j-1.2-api (source) dependencies minor 2.21.0 -> 2.24.1

Configuration

📅 Schedule: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot

solrbot avatar Oct 29 '23 01:10 solrbot

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: undefined
Command failed: ./gradlew updateLicenses
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
/home/ubuntu/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-api/2.23.1/9c15c29c526d9c6783049c0a77722693c66706e1/log4j-api-2.23.1.jar(/org/apache/logging/log4j/Level.class): warning: Cannot find annotation method 'value()' in type 'BaselineIgnore': class file for aQute.bnd.annotation.baseline.BaselineIgnore not found
error: warnings found and -Werror specified
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error
1 warning

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':solr:test-framework:compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
> Run with --info option to get more log output.

BUILD FAILED in 29s

solrbot avatar Dec 08 '23 09:12 solrbot

This upgrade was tricky. First, it did not compile unless upgrading biz.aQute.bnd to v7.0.0. After that, the build fails, complaining about class versions:

/home/runner/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-api/2.23.0/10741ddf9effd8e04d568148c2948a22f3f4cc73/log4j-api-2.23.0.jar(/org/apache/logging/log4j/Level.class): warning: Cannot find annotation method 'value()' in type 'BaselineIgnore': bad class file: /home/runner/.gradle/caches/modules-2/files-2.1/biz.aQute.bnd/biz.aQute.bnd.annotation/7.0.0/8ad279ebf0d04ea89c5ce4d934189d0d16bb6d50/biz.aQute.bnd.annotation-7.0.0.jar(/aQute/bnd/annotation/baseline/BaselineIgnore.class)
    class file has wrong version 61.0, should be 55.0

I cannot see that Log4j have officially announced that they require Java 17, although their release note page at https://logging.apache.org/log4j/2.x/release-notes.html says for the 2.22.1 release: "While maintaining compatibility with Java 8, the artifacts in this release where generated using JDK 17, unlike version 2.22.0 that used JDK 11.".

@uschindler Can you decode what they mean by this and whether this is likely a bug in the 2.23.0 release or if we cannot upgrade since they require java17?

PS: We should start thinking about JDK bump for Solr on main to at least 17.

janhoy avatar Feb 29 '24 18:02 janhoy

I see from https://github.com/apache/logging-log4j2/issues/2232 and other discussions that log4j now tells users to include Log4j as runtime scope, not compile scope, and not to interact programmatically with the library (like we do).

janhoy avatar Feb 29 '24 20:02 janhoy

Unfortunate that we cannot upgrade due to requirement for Java 17 in a minor release... So will have to stick with the one we have I guess...

janhoy avatar Apr 10 '24 12:04 janhoy

Similar to #1821 i.e. blocked on JDK 17+ -- if I find a third solrbot PR like it I'll create a JIRA and then close out these in favour of that.

https://github.com/apache/solr/pull/1821#issuecomment-2049409176

cpoerschke avatar Apr 11 '24 10:04 cpoerschke

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: undefined
Command failed: ./gradlew updateLicenses
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
/home/ubuntu/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-api/2.23.1/9c15c29c526d9c6783049c0a77722693c66706e1/log4j-api-2.23.1.jar(/org/apache/logging/log4j/Level.class): warning: Cannot find annotation method 'value()' in type 'BaselineIgnore': class file for aQute.bnd.annotation.baseline.BaselineIgnore not found
error: warnings found and -Werror specified
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error
1 warning

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':solr:test-framework:compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
> Run with --info option to get more log output.

BUILD FAILED in 31s

solrbot avatar Jul 16 '24 20:07 solrbot