solr icon indicating copy to clipboard operation
solr copied to clipboard
verified publisher icon apache

SOLR-17037 - Clone LTRScoringQuery on rewriting to preserve queryResultCache key

Open softwaredoug opened this issue 2 years ago • 5 comments

https://issues.apache.org/jira/browse/SOLR-17037

Description

Clone the LTRScoringQuery during rewriting so it benefits from the cache

Solution

Clone the LTRScoringQuery during rewriting so it benefits from the cache

Tests

See added test that repros, which is now fixed.

Checklist

Please review the following and check all that apply:

  • [X] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • [X] I have created a Jira issue and added the issue ID to my pull request title.
  • [ ] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • [X] I have developed this patch against the main branch.
  • [x] I have run ./gradlew check.
  • [x] I have added tests for my changes.
  • [ ] I have added documentation for the Reference Guide

softwaredoug avatar Oct 18 '23 12:10 softwaredoug

Looks like I broke some interleaving test, looking into that...

softwaredoug avatar Oct 18 '23 15:10 softwaredoug

Fixed the interleaving tests :)

softwaredoug avatar Oct 18 '23 21:10 softwaredoug

Thanks @softwaredoug for the contribution! Pretty sure my colleague @aruggero worked on this as well, but can't remember if she wrote any blog on it or if she has any further consideration!

alessandrobenedetti avatar Oct 20 '23 10:10 alessandrobenedetti

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution!

github-actions[bot] avatar Jan 26 '24 23:01 github-actions[bot]

This PR has had no activity for 60 days and is now labeled as stale. Any new activity or converting it to draft will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the [email protected] mailing list. Thank you for your contribution!

github-actions[bot] avatar Aug 20 '24 00:08 github-actions[bot]

This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again.

github-actions[bot] avatar Oct 20 '24 00:10 github-actions[bot]