solr icon indicating copy to clipboard operation
solr copied to clipboard

SOLR-15474: Support Pluggable Circuit Breakers

Open atris opened this issue 4 years ago • 5 comments

This commit introduces the capability of adding new circuit breakers on the fly by specifying the circuit breaker and its parameters in solrconfig.xml.

Previously, it was possible to plug in new circuit breakers by plugging in a custom CircuitBreakerManager. This commit makes it more elastic by allowing circuit breaker level pluggability.

CircuitBreakerConfig remains to support tests but is no longer used in the core code path.

atris avatar Jun 25 '21 10:06 atris

@janhoy @dsmiley @cpoerschke Please review

atris avatar Jun 28 '21 06:06 atris

@janhoy Updated the PR, please see if the approach looks fine to you.

atris avatar Jul 05 '21 06:07 atris

@cpoerschke Updated, let me know if it looks fine

atris avatar Jul 06 '21 11:07 atris

... This branch has conflicts that must be resolved ...

I'll have a go at resolving them.

cpoerschke avatar Jul 08 '21 10:07 cpoerschke

I see you are awaiting my review on this. Would you mind bringing it up to date and resolve conversations that are settled, and then spell out where you need help to land this great improvement? I'll probably have some time next week to take the PR for a spin.

janhoy avatar Oct 21 '21 22:10 janhoy

@atris It is unclear to me what remains to land this fine PR. Where is review still needed? Where is help still needed?

janhoy avatar Jun 02 '23 08:06 janhoy

Superceded by #1725

janhoy avatar Jun 27 '23 22:06 janhoy