apache
SOLR-15469: start/stop script fails on multiple instances
https://issues.apache.org/jira/browse/SOLR-15469
Description
When more instances of solr run on the same machine. The bash script solr fail to get correct pid of process. This cause problems to get status information or when stop/restart solr instance.
In optical to use solr like a cluster service this is essential for the cluster to know the healt of service.
Solution
I used $SOLR_HOME in grep expression to recognize the right process on which you want to operate.
@piuma Are there similar changes that we can should make for the windows side of things?
This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@piuma I would be interested in picking this back up if you could contribute a BATS test demonstrating the error first. That would make verifying the fix a lot easier ;-). Take a look at https://github.com/apache/solr/blob/main/solr/packaging/test/test_start_solr.bats.
This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution!
Longer term, we want to rethink how our start and stop commands are managed. There is definitly better ways of handling them, including moving more shared logic into Java code from the windows/shell scripts, and thinking through situations like this one. I'm going to close this PR for now.