solr icon indicating copy to clipboard operation
solr copied to clipboard

SOLR-15920 ReleaseWizard - Upgrade 'consolemenu' dependency to v0.7.1

Open janhoy opened this issue 3 years ago • 1 comments

https://issues.apache.org/jira/browse/SOLR-15920

Basically get rid of custom code which is now part of upstream 'consolemenu.

janhoy avatar Sep 17 '22 21:09 janhoy

@HoustonPutman I think this is good to go, but would appreciate a quick check. 92 lines deleted :)

janhoy avatar Sep 28 '22 22:09 janhoy

That’s strange since the holiday rep was not changed. Unless a new dependency upgrade triggered a lib upgrade with this change. The requirements.txt should perhaps lock major version of dependencies instead of specifying minimum version.

janhoy avatar Oct 15 '22 20:10 janhoy

Mystery solved. We have pip requirement holidays>=0.9.10 and in 0.15 released this autust they removed England

Drop support for UK subdivisions as countries (England, Scotland..) (dr-p)

I'll make the change to UK and pin version to 0.15

janhoy avatar Oct 15 '22 21:10 janhoy

I see Ishan already did the UK change, thanks. So committed a change to requirements.txt to pin all lib versions to avoid future surprises.

janhoy avatar Oct 15 '22 21:10 janhoy

:warning: 314 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

sonatype-lift[bot] avatar Oct 15 '22 21:10 sonatype-lift[bot]