solr-operator icon indicating copy to clipboard operation
solr-operator copied to clipboard

fix(deployment.yaml): correct the placement and syntax of the imagePu…

Open fruit-ninja opened this issue 9 months ago • 1 comments

  • Provide a fix for the imagePullSecret value that allows Solr Operator users to host the image in their own repositories, protected by authentication. This fix will continue to accept an imagePullSecret to facilitate these use cases but in the correct format in the deployment.yaml
  • I tested the original enhancement #734 from @gerlowskija (Thank you!!!) to add in the request for issue #718 but I was still getting an error where it was not using my secret for authentication.
  • I found the correct format from the official Kubernetes docs and this Stack Overflow solution. The imagePullSecrets should be placed in spec section.
  • This fix has been tested to be working and correctly authenticating to my private repository.

fruit-ninja avatar Apr 12 '25 03:04 fruit-ninja

@HoustonPutman @gerlowskija would y'all please help me review this PR whenever you get an opportunity? Thank you!

fruit-ninja avatar May 16 '25 02:05 fruit-ninja