solr-operator icon indicating copy to clipboard operation
solr-operator copied to clipboard

feat(update-security-json): Update security.json when secret is updated

Open mcarroll1 opened this issue 1 year ago • 0 comments

This feature is targeting this issue

  • Added Ovewrite flag (defaults to false). If flag is true, setup-zk initContainer will check applied security.json against version in the secret and apply if there is a diff
  • Updated descriptions about maxPodsUnavailable, as negative numbers don't appear to be work
  • Was running into issues with GINGKO_PARAMS when running integration tests, so added a default

The integration test is a bit blunt, but I wasn't sure how to demonstrate auth being applied. I tried creating a curl pod to curl solr, but was facing issues connecting to the two. I ended up changing the auth that the operator connects to solr with as a means of demonstrating.

The test takes a couple minutes to run. Please give any feedback on what I could do differently there. You can see the curl attempt in 1a7bb57. Also I'm unsure if I updated the CRD correctly, as it's generating some unexpected diffs.

This feature is important to the CI for my team, hence me adding two features around security.json in short order.

mcarroll1 avatar Jan 15 '25 16:01 mcarroll1