solr-operator icon indicating copy to clipboard operation
solr-operator copied to clipboard

fix: avoid reset of security.json if get fails (#659)

Open smoldenhauer-ish opened this issue 1 year ago • 3 comments

smoldenhauer-ish avatar Nov 27 '23 10:11 smoldenhauer-ish

adapted the expected setup-zk command and tested locally make prepare check and the end tests make e2e-tests SOLR_IMAGE=solr:8.11

smoldenhauer-ish avatar Nov 29 '23 12:11 smoldenhauer-ish

@smoldenhauer-ish your PR is from an organizational fork, so I'm unable to push a changelog entry, but can you merge main into your branch, then add the following changelog entry to helm/solr-operator/chart.yaml?

    - kind: fixed
      description: Avoid reset of security.json if get request fails  
      links:
        - name: Github Issue
          url: https://github.com/apache/solr-operator/issues/659
        - name: Github PR
          url: https://github.com/apache/solr-operator/pull/660

I'll be good to merge this after you do that!

HoustonPutman avatar Mar 26 '24 17:03 HoustonPutman

Added the changes entry - The 'edit by maintainers' is only available to private owned forks?

smoldenhauer-ish avatar Mar 27 '24 08:03 smoldenhauer-ish