skywalking icon indicating copy to clipboard operation
skywalking copied to clipboard

Adopt license eye to check dependencies' license

Open kezhenxu94 opened this issue 2 years ago • 0 comments

  • [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • [x] Update the CHANGES log.

This is still not perfect, for example there are some duplicate dependencies that the maven resolver needs more enhancements, but that doesn't matter too much IMO.

kezhenxu94 avatar Jun 14 '22 08:06 kezhenxu94

B87A0F06-8E4C-4FC2-BBFD-77EBDCDB3DD0

wu-sheng avatar Aug 21 '22 10:08 wu-sheng

B87A0F06-8E4C-4FC2-BBFD-77EBDCDB3DD0

this is expected, we run the dependency check only when there is any pom.xml file changed, which is not the case in this PR

kezhenxu94 avatar Aug 21 '22 10:08 kezhenxu94

I'll very soon open another PR with pom.xml file changed to verify this.

kezhenxu94 avatar Aug 21 '22 10:08 kezhenxu94