[Bug] Owner field doesn't work correctly

[yibin87]

Search before asking

• [X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component

License Tools (apache/skywalking-eyes)

What happened

I use skywalking-eyes(go install go install github.com/apache/skywalking-eyes/cmd/license-eye@latest) to do some license check works. Find the "copyright-owner" attribute doesn't work correctly. For example: Even when I specify copyright-owner: Bla-Bla, then on the license header,

header:
  license:
    spdx-id: Apache-2.0
    copyright-owner: Bla-Bla

I check:

// Copyright 2022 Alb-Alb
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

Then the file can pass the license check, which is weired.

What you expected to happen

I expect the tool can detect such cases and report an error.

How to reproduce

Refer to the "what happened" section,

Anything else

No response

Are you willing to submit PR?

• [ ] Yes I am willing to submit a PR!

Code of Conduct

• [X] I agree to follow this project's Code of Conduct

[kezhenxu94]

@yibin87 please provide full steps that you do

[wu-sheng]

Find the "copyright-owner" attribute doesn't work correctly. For example:
Even when I specify copyright-owner: Bla-Bla, then on the license header, I write:
// Copyright 2022 Alb-Alb
// XXXXXXX

I think this is not how APLv2 adopts the owner. I am not sure what is the license.

[yibin87]

Find the "copyright-owner" attribute doesn't work correctly. For example:
Even when I specify copyright-owner: Bla-Bla, then on the license header, I write:
// Copyright 2022 Alb-Alb
// XXXXXXX

I think this is not how APLv2 adopts the owner. I am not sure what is the license.

https://spdx.org/licenses/Apache-2.0.html， according to this page， Standard License Header.

[yibin87]

@yibin87 please provide full steps that you do

@kezhenxu94 Added more details in issue descriptions.

[kezhenxu94]

This is an issue as the copyright-owner is normalized so it won't effect the header check result, it will be used in header fix only. We need to take that into consideration

[wu-sheng]

@yibin87 One about the header, from the Apache Software Foundation perspective, this is the standard header

/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *
 */

This is why I felt strange about the description.

This is an issue as the copyright-owner is normalized so it won't effect the header check result, it will be used in header fix only. We need to take that into consideration

Are the header checker and fixer using different templates? I mean only when they are, the owner could work in one side only, right? @kezhenxu94

[wu-sheng]

No update for a year.