skywalking
skywalking copied to clipboard
[Feature] [Nodejs] intercept the http.get
Search before asking
- [X] I had searched in the issues and found no similar feature requirement.
Description
The plugin HttpPlugin
of nodejs agent not intercept the method http.get
Use case
No response
Related issues
No response
Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
Code of Conduct
- [x] I agree to follow this project's Code of Conduct
Are you going to submit a pull request about this?
could I work on this?
could I work on this?
Yes thanks!
Hi @kezhenxu94 @chzhuo. How can I replicate this issue and what is the expected outcome after the fix?
I've tested by setting skywalker up locally and both client and server side GET requests are viewable in the /dashboard/GENERAL/Service/c2VydmVy.1/General-Service route of the UI
PS - I tested by running https://github.com/apache/skywalking-nodejs/tree/v0.5.1/tests/plugins/http locally
Hi @kezhenxu94 @chzhuo. How can I replicate this issue and what is the expected outcome after the fix?
I've tested by setting skywalker up locally and both client and server side GET requests are viewable in the /dashboard/GENERAL/Service/c2VydmVy.1/General-Service route of the UI
PS - I tested by running https://github.com/apache/skywalking-nodejs/tree/v0.5.1/tests/plugins/http locally
Can you try to reproduce by changing this to http.get?
https://github.com/apache/skywalking-nodejs/blob/289e8af995cb0702adabacccd669c10974299411/tests/plugins/http/client.ts#L30
Lack of information about how to reproduce from the reporter.