skywalking icon indicating copy to clipboard operation
skywalking copied to clipboard

[Feature] inject Python agent automatically in SWCK

Open kezhenxu94 opened this issue 4 years ago • 18 comments

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Description

Since https://github.com/apache/skywalking-python/pull/159 is merged, we have Docker image for SkyWalking Python agent and non-intrusive way to install the agent, it would be perfect if we can also enhance SWCK to make it possible to inject the Python agent automatically when Kubernetes annotation is specified.

Use case

When users label a Kubernetes Pod with a special annotation, for example, swck-java-agent-injected=true, SWCK can automatically inject the Python agent to the application Pod, hence the users don't even need to modify their Docker image.

Related issues

Java agent injector: https://github.com/apache/skywalking-swck/pull/30

https://github.com/apache/skywalking-python/pull/159 https://github.com/apache/skywalking/issues/7461

Are you willing to submit a PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

kezhenxu94 avatar Sep 09 '21 06:09 kezhenxu94

@Superskyyy FYI 😉

kezhenxu94 avatar Sep 09 '21 06:09 kezhenxu94

Do I wait the Java PR to be ready first? In case something can be reused. Looks like a very big feature there base on the LOC.

Superskyyy avatar Sep 12 '21 17:09 Superskyyy

@hanahmily Please confirm tye statue of that PR.

wu-sheng avatar Sep 13 '21 00:09 wu-sheng

@Superskyyy FYI https://github.com/apache/skywalking-swck/pull/30 is merged

kezhenxu94 avatar Sep 15 '21 07:09 kezhenxu94

@Superskyyy FYI apache/skywalking-swck#30 is merged

Okay, my turn then.

Superskyyy avatar Sep 15 '21 12:09 Superskyyy

@Superskyyy Could you try to finish this? I hope we could move forward 1.0 soon.

wu-sheng avatar Feb 14 '22 07:02 wu-sheng

@Superskyyy Could you try to finish this? I hope we could move forward 1.0 soon.

@wu-sheng I would try my best to proceed soon, so that hopefully we could go to 1.0.0 in early March. Sorry for the delays, I had to focus on my graduate research on service mesh recently.

Superskyyy avatar Feb 16 '22 20:02 Superskyyy

Service Mesh is good to learn :)

wu-sheng avatar Feb 16 '22 22:02 wu-sheng

Hi @Superskyyy , @fgksgf is interested in this issue and he has enough available time recently so I just suggested him to take a look at this. Please comment here if you've already started, in case.

kezhenxu94 avatar Apr 07 '22 01:04 kezhenxu94

Hi @Superskyyy , @fgksgf is interested in this issue and he has enough available time recently so I just suggested him to take a look at this. Please comment here if you've already started, in case.

Hello! Actually, I already started implementing this one last week, I was planning to finish it this month and go for the 1.0.0 milestone. Can we see if there's another work that is suitable for @fgksgf?

Superskyyy avatar Apr 07 '22 19:04 Superskyyy

Hi @Superskyyy , @fgksgf is interested in this issue and he has enough available time recently so I just suggested him to take a look at this. Please comment here if you've already started, in case.

Hello! Actually, I already started implementing this one last week, I was planning to finish it this month and go for the 1.0.0 milestone. Can we see if there's another work that is suitable for @fgksgf?

Ok, good luck :)

fgksgf avatar Apr 08 '22 01:04 fgksgf

@Superskyyy @dashanji Is anyone planning to do this? It is stable for years.

wu-sheng avatar Aug 18 '23 06:08 wu-sheng

@Superskyyy @dashanji Is anyone planning to do this? It is stable for years.

@rabajaj0509 is interested in this and may work on this after he finishes the GSoC program

kezhenxu94 avatar Aug 18 '23 07:08 kezhenxu94

@Superskyyy @dashanji Is anyone planning to do this? It is stable for years.

@rabajaj0509 is interested in this and may work on this after he finishes the GSoC program

Lets hand it to Rahul :), things are out of hand for me currently.

Superskyyy avatar Aug 18 '23 19:08 Superskyyy

Yes, I will start working on this next week.

rabajaj0509 avatar Aug 19 '23 01:08 rabajaj0509

Yes, I will start working on this next week.

Thanks man!

Superskyyy avatar Aug 19 '23 01:08 Superskyyy

Looking into this one now.

rabajaj0509 avatar Aug 29 '23 04:08 rabajaj0509

Looking into this one now.

Hi @rabajaj0509, thanks for the interest. FYI, https://github.com/apache/skywalking-swck/blob/master/docs/how-to-add-new-crd-and-controller.md

dashanji avatar Sep 06 '23 07:09 dashanji