skywalking
skywalking copied to clipboard
[Feature] inject Python agent automatically in SWCK
Search before asking
- [X] I had searched in the issues and found no similar feature requirement.
Description
Since https://github.com/apache/skywalking-python/pull/159 is merged, we have Docker image for SkyWalking Python agent and non-intrusive way to install the agent, it would be perfect if we can also enhance SWCK to make it possible to inject the Python agent automatically when Kubernetes annotation is specified.
Use case
When users label a Kubernetes Pod with a special annotation, for example, swck-java-agent-injected=true, SWCK can automatically inject the Python agent to the application Pod, hence the users don't even need to modify their Docker image.
Related issues
Java agent injector: https://github.com/apache/skywalking-swck/pull/30
https://github.com/apache/skywalking-python/pull/159 https://github.com/apache/skywalking/issues/7461
Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
@Superskyyy FYI 😉
Do I wait the Java PR to be ready first? In case something can be reused. Looks like a very big feature there base on the LOC.
@hanahmily Please confirm tye statue of that PR.
@Superskyyy FYI https://github.com/apache/skywalking-swck/pull/30 is merged
@Superskyyy Could you try to finish this? I hope we could move forward 1.0 soon.
@Superskyyy Could you try to finish this? I hope we could move forward 1.0 soon.
@wu-sheng I would try my best to proceed soon, so that hopefully we could go to 1.0.0 in early March. Sorry for the delays, I had to focus on my graduate research on service mesh recently.
Service Mesh is good to learn :)
Hi @Superskyyy , @fgksgf is interested in this issue and he has enough available time recently so I just suggested him to take a look at this. Please comment here if you've already started, in case.
Hi @Superskyyy , @fgksgf is interested in this issue and he has enough available time recently so I just suggested him to take a look at this. Please comment here if you've already started, in case.
Hello! Actually, I already started implementing this one last week, I was planning to finish it this month and go for the 1.0.0 milestone. Can we see if there's another work that is suitable for @fgksgf?
Hi @Superskyyy , @fgksgf is interested in this issue and he has enough available time recently so I just suggested him to take a look at this. Please comment here if you've already started, in case.
Hello! Actually, I already started implementing this one last week, I was planning to finish it this month and go for the 1.0.0 milestone. Can we see if there's another work that is suitable for @fgksgf?
Ok, good luck :)
@Superskyyy @dashanji Is anyone planning to do this? It is stable for years.
@Superskyyy @dashanji Is anyone planning to do this? It is stable for years.
@rabajaj0509 is interested in this and may work on this after he finishes the GSoC program
@Superskyyy @dashanji Is anyone planning to do this? It is stable for years.
@rabajaj0509 is interested in this and may work on this after he finishes the GSoC program
Lets hand it to Rahul :), things are out of hand for me currently.
Yes, I will start working on this next week.
Yes, I will start working on this next week.
Thanks man!
Looking into this one now.
Looking into this one now.
Hi @rabajaj0509, thanks for the interest. FYI, https://github.com/apache/skywalking-swck/blob/master/docs/how-to-add-new-crd-and-controller.md