skywalking icon indicating copy to clipboard operation
skywalking copied to clipboard

[Feature] Support to query relation metrics through PromQL

Open wu-sheng opened this issue 1 year ago • 10 comments

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Description

PromQL Service doesn't support metrics of relation between services, instances or endpoints.

Use case

User could use this to build dashboards to show metrics from the lines on the topology or manually click.

Related issues

No response

Are you willing to submit a pull request to implement this on your own?

  • [ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

wu-sheng avatar May 22 '24 02:05 wu-sheng

@CzyerChen @weixiang1862 @yswdqz Any of you has interest in implementing this?

wu-sheng avatar May 22 '24 02:05 wu-sheng

I am new to this repo - would like to pick this up. Can you add some more verbose details of what is required as part of the feature?

theboywholived avatar May 22 '24 11:05 theboywholived

I am new to this repo - would like to pick this up.

Can you add some more verbose details of what is required as part of the feature?

This is not easy. Do you read most of SkyWalking codebases?

wu-sheng avatar May 22 '24 11:05 wu-sheng

I will have to do that. I am brand-new to this repo.

theboywholived avatar May 22 '24 11:05 theboywholived

I would say, you could consider to implement this. But don't be in urgent.

This requires you to have good understanding of the whole system.

wu-sheng avatar May 22 '24 11:05 wu-sheng

I would like to take a shot at this. I will go through the docs and readme. Is there anything else you suggest me to do? Or a similar MR for a different Query language?

theboywholived avatar May 22 '24 11:05 theboywholived

You could do as following

  1. Get familiar with project, and how to run showcase. https://skywalking.apache.org/docs/skywalking-showcase/next/readme/
  2. Learn MQE about the protocol and native UI for relative metrics.
  3. Learn PromQL service, and workflow.
  4. Try to implement this.

wu-sheng avatar May 22 '24 11:05 wu-sheng

Okay, let me do as you recommend.

theboywholived avatar May 22 '24 13:05 theboywholived

@wu-sheng I only have 16 GB RAM in my mac, I am not able to run showcase: Release "demo" does not exist. Installing it now. It's stuck on this step with RAM Utilization spiking up.

Is there another alternative?

theboywholived avatar May 25 '24 08:05 theboywholived

You need to run necessary components only. Don't run the default. It includes all features.

wu-sheng avatar May 25 '24 08:05 wu-sheng

@yswdqz told me, he will work on this from June 2nd/3th.

wu-sheng avatar May 29 '24 01:05 wu-sheng