skywalking-query-protocol
skywalking-query-protocol copied to clipboard
Support async profiler feature
The OSPP is closing to an end, less than 24h. You submit this PR at this moment, I am not sure how much effect I could take on this.
For a feature like you are doing, it is hard to be accepted without several weeks review.
The OSPP is closing to an end, less than 24h. You submit this PR at this moment, I am not sure how much effect I could take on this.
For a feature like you are doing, it is hard to be accepted without several weeks review.
As I understood, the PR/MR can be reviewed during the October. 30th Sept is just the deadline of the PR submission.
https://summer-ospp.ac.cn/
Then, I will keep this open until I can see the whole PR opened. I haven't heard the update since the last meeting. Now, national day holidays are coming. I could only join further discussion after that.
The protocol usage process is roughly like this
1. Add AsyncProfiler to the service monitoring page
2. You can use the "queryData" interface to get the instance ID that can perform "profiling"
3. Create a "profling" task through the "createAsyncProfilerTask" interface
4. Query "profling" tasks through the "queryAsyncProfilerTaskList" interface
5. Query the instance ID of the successful execution through the "queryAsyncProfilerTaskProgress" interface
6. Use "queryAsyncProfilerAnalyze" to analyze the performance of the successfully executed instance
And the wireframe diagram can see at: https://o0iubh7znc2.feishu.cn/docx/T5HmdNZCdo0f7yx2BiIcvDpknrc#share-H3crdHRjPo1Pihx63b2chJ1mnRb
Here are some image descriptions in case the above links are invalid:
1. home page
2. when user click details button
3. when user click create task button
And the wireframe diagram can see at: https://o0iubh7znc2.feishu.cn/docx/T5HmdNZCdo0f7yx2BiIcvDpknrc#share-H3crdHRjPo1Pihx63b2chJ1mnRb
It would be better you paste the image here alongside with the online docs
I think we should search by following created time(desc) only, right? We don't have extra conditions which ppl know.
I think we should search by following created time(desc) only, right? We don't have extra conditions which ppl know.
Yes, There can only query by time and serviceId(This is fixed in this page), and the returned data is sorted in descending order of createTime. I made a correction in the wireframe diagram.
The protocol usage process is roughly like this
1. Add AsyncProfiler to the service monitoring page 2. You can use the "queryData" interface to get the instance ID that can perform "profiling" 3. Create a "profling" task through the "createAsyncProfilerTask" interface 4. Query "profling" tasks through the "queryAsyncProfilerTaskList" interface 5. Query the instance ID of the successful execution through the "queryAsyncProfilerTaskProgress" interface 6. Use "queryAsyncProfilerAnalyze" to analyze the performance of the successfully executed instanceAnd the wireframe diagram can see at: https://o0iubh7znc2.feishu.cn/docx/T5HmdNZCdo0f7yx2BiIcvDpknrc#share-H3crdHRjPo1Pihx63b2chJ1mnRb
Here are some image descriptions in case the above links are invalid:
- home page
2. when user click details button
3. when user click create task button
![]()
@Fine0830 Could you confirm this works for a new widget? We will need that later.
I think we should search by following created time(desc) only, right? We don't have extra conditions which ppl know.
2. when user click details button
3. when user click create task button