skywalking-java icon indicating copy to clipboard operation
skywalking-java copied to clipboard

[plugin][pulsar] Handle the SendCallback method sign changed.

Open dao-jun opened this issue 1 year ago • 2 comments

In https://github.com/apache/pulsar/pull/22940, Pulsar will change the org.apache.pulsar.client.impl.SendCallback#sendComplete method sign from

public void sendComplete(Exception e)

to

public void sendComplete(Throwable t, OpSendMsgStats stats)

This PR is to address it.

dao-jun avatar Aug 19 '24 23:08 dao-jun

Please fix CI and we need to add the new versions to the test scenarios to verify.

Also, you need to make CI passed.

wu-sheng avatar Aug 20 '24 00:08 wu-sheng

Could you fix the CI first? Then we need to wait for Pulsar's next release.

wu-sheng avatar Aug 21 '24 02:08 wu-sheng

No update for a month. Close for now.

wu-sheng avatar Sep 23 '24 06:09 wu-sheng