skywalking-java icon indicating copy to clipboard operation
skywalking-java copied to clipboard

Add plugin to support micronaut (#9429)

Open pg-yang opened this issue 2 years ago • 5 comments

  • [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • [x] Update the CHANGES log.

Closes https://github.com/apache/skywalking/issues/9429 Support Micronaut http server/client

pg-yang avatar Aug 09 '22 08:08 pg-yang

When I run test . The docker logs in skywalking/agent-test-jvm:1.0.0 show it 's successful:

endTo receive actual data
To validate
Scenario[micronaut-http-scenario-3.6.0] passed!

But the shell execute failed:

+ mv ./target/micronaut-http-scenario.jar ./target/micronaut-http-scenario.zip /Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0
+ java -jar -Xmx256m -Xms256m -Dconfigure.file=/Users/{work_space}/skywalking-java/test/plugin/scenarios/micronaut-http-scenario/configuration.yml -Dscenario.home=/Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0 -Dscenario.name=micronaut-http-scenario -Dscenario.version=3.6.0 -Doutput.dir=/Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0 -Dagent.dir=/Users/{work_space}/skywalking-java/test/plugin/../../skywalking-agent -Djacoco.home=/Users/{work_space}/skywalking-java/test/plugin/../jacoco -Ddebug.mode= -Ddocker.image.version=1.0.0 /Users/{work_space}/skywalking-java/test/plugin/dist/plugin-runner-helper.jar
+ [[ 0 -ne 0 ]]
+ echo 'start container of testcase.name=micronaut-http-scenario-3.6.0'
start container of testcase.name=micronaut-http-scenario-3.6.0
+ bash /Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0/scenario.sh
/Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0/scenario.sh: line 57: /Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0/logs/container.log: No such file or directory
+ status=0
+ [[ 0 == 0 ]]
+ [[ -z '' ]]
+ rm -rf /Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0
rm: /Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0/agent: Permission denied
rm: /Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0: Permission denied

The similar situation happened in github test (focus on No such file or directory )

[ERROR] Scenario[micronaut-http-scenario-3.6.0] failed!
/home/runner/work/skywalking-java/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0/scenario.sh: line 57: /home/runner/work/skywalking-java/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0/logs/container.log: No such file or directory
Error: Process completed with exit code 1.

pg-yang avatar Aug 09 '22 16:08 pg-yang

I think this is the error

SegmentSizeNotEqualsException: micronaut-scenario 1119 expected: ge 5 1120 actual: 2

wu-sheng avatar Aug 09 '22 23:08 wu-sheng

Any update?

wu-sheng avatar Aug 11 '22 07:08 wu-sheng

When I run test . The docker logs in skywalking/agent-test-jvm:1.0.0 show it 's successful:


endTo receive actual data

To validate

Scenario[micronaut-http-scenario-3.6.0] passed!

But the shell execute failed:


+ mv ./target/micronaut-http-scenario.jar ./target/micronaut-http-scenario.zip /Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0

+ java -jar -Xmx256m -Xms256m -Dconfigure.file=/Users/{work_space}/skywalking-java/test/plugin/scenarios/micronaut-http-scenario/configuration.yml -Dscenario.home=/Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0 -Dscenario.name=micronaut-http-scenario -Dscenario.version=3.6.0 -Doutput.dir=/Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0 -Dagent.dir=/Users/{work_space}/skywalking-java/test/plugin/../../skywalking-agent -Djacoco.home=/Users/{work_space}/skywalking-java/test/plugin/../jacoco -Ddebug.mode= -Ddocker.image.version=1.0.0 /Users/{work_space}/skywalking-java/test/plugin/dist/plugin-runner-helper.jar

+ [[ 0 -ne 0 ]]

+ echo 'start container of testcase.name=micronaut-http-scenario-3.6.0'

start container of testcase.name=micronaut-http-scenario-3.6.0

+ bash /Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0/scenario.sh

/Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0/scenario.sh: line 57: /Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0/logs/container.log: No such file or directory

+ status=0

+ [[ 0 == 0 ]]

+ [[ -z '' ]]

+ rm -rf /Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0

rm: /Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0/agent: Permission denied

rm: /Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0: Permission denied



The similar situation happened in github test (focus on No such file or directory )


[ERROR] Scenario[micronaut-http-scenario-3.6.0] failed!

/home/runner/work/skywalking-java/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0/scenario.sh: line 57: /home/runner/work/skywalking-java/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0/logs/container.log: No such file or directory

Error: Process completed with exit code 1.

I need resolve this problem on my PC . maybe tomorrow

pg-yang avatar Aug 11 '22 09:08 pg-yang

@wu-sheng I open a discussion about rm: /Users/{work_space}/skywalking-java/test/plugin/workspace/micronaut-http-scenario/3.6.0/agent: Permission denied when execute test

https://github.com/apache/skywalking/discussions/9465

pg-yang avatar Aug 11 '22 16:08 pg-yang

Actually, my test scenarios is always right on my PC , wether macos (use -- debug skip cleanup) or ubuntu . I have modified the code , but i'm not sure if CI/CD can pass . BTW, if I push too many times, will it bother you?

pg-yang avatar Aug 14 '22 06:08 pg-yang

It is fine, just don't keep pushing to make other PRs blocked.

wu-sheng avatar Aug 14 '22 06:08 wu-sheng

Is there other way to look detail info about CI/CD process。 No any idea on the error . It's right on PC .

image

pg-yang avatar Aug 14 '22 10:08 pg-yang

The logs are there. There is no other way.

wu-sheng avatar Aug 14 '22 10:08 wu-sheng

The reason of we insisted e2e plugin test, rather than screenshots, is this is the only way we could verify codes automatically. We had confirmed many issues before due to this test process. Be patient, run tests on Linux, make sure the process working as many other ppl did.

wu-sheng avatar Aug 14 '22 10:08 wu-sheng

You could change the GHA control file to run this particular task on your own fork's GitHub Action.

The upstream resource is very limited.

wu-sheng avatar Aug 16 '22 13:08 wu-sheng

You don't have to run all these on upstream, and wait for hours to get an error log.

wu-sheng avatar Aug 16 '22 13:08 wu-sheng

OK, my PC can‘t reproduce the error , I will try it

pg-yang avatar Aug 16 '22 13:08 pg-yang

Your changes seem breaking E2E / Basic function + gRPC transport(Java8) (pull_request) test too. This should make your attention as usually, a plugin contribution should affect this, but I have seen this test failing every time.

wu-sheng avatar Aug 16 '22 13:08 wu-sheng

I shouldn't ignore any error message . And need more patience . Maybe It's a good chance to understand github action , this project , and other something .

pg-yang avatar Aug 16 '22 13:08 pg-yang

Just remain my test-scenario. And submit PR to main in my repo . Very Thanks . I will work on this plugin .Don't worry . If I'm ready let you know . Finally , should I close this PR ?

pg-yang avatar Aug 16 '22 14:08 pg-yang

Either is fine. It is up to you.

wu-sheng avatar Aug 16 '22 14:08 wu-sheng

@wu-sheng I'm ready , Test / micronaut-http-scenario is successful.

pg-yang avatar Aug 19 '22 03:08 pg-yang

Please notice to resolve conflicts as another plugin PR has been merged.

wu-sheng avatar Aug 19 '22 07:08 wu-sheng