apache
fix: The way filepath.Join is used when handling package names doesn't properly account for windows.
The use of filepath.Join when handling package names does not properly account for Windows. This issue allows the application to compile on Windows, but it causes interceptors to be bypassed.
After this change, is the agent able to instrument go app compiling on Windows? If so, we should at least add one plugin test on Windows to verify.
https://github.com/apache/skywalking-go/actions/runs/14648116633/job/41125628067?pr=219
Please run lint locally, and fix the issue.
After this change, is the agent able to instrument go app compiling on Windows? If so, we should at least add one plugin test on Windows to verify.
So far, it’s working fine on my Windows. I think we could add a plugin test similar to the macOS one, but does it need to be done in this PR?
Yes, you could send a new pull request to add a windows GHA control file, without any actual tests as this isn't merged. Then we could sync that file to this PR.
The reason I asked for this is that, GHA file would not run before merging. We need the file accepted.
Yes, you could send a new pull request to add a windows GHA control file, without any actual tests as this isn't merged. Then we could sync that file to this PR.是的，您可以发送一个新的拉取请求来添加 Windows GHA 控制文件，无需进行任何实际测试，因为该文件尚未合并。然后我们可以将该文件同步到此 PR。
The reason I asked for this is that, GHA file would not run before merging.我这样要求的原因是，GHA 文件在合并之前不会运行。 We need the file accepted.我们需要接受该文件。
I'll do this.
@navanis Could you submit the required and mock GHA control file for Windows compiling through another PR first? As explained, we need to merge that first.
@mrproliu Could you check the CI env? It seems to have docker compose version error.