skywalking-client-js icon indicating copy to clipboard operation
skywalking-client-js copied to clipboard

support to "import ClientMonitor from 'skywalking-client-js'" in "typescript" and "es6"

Open vihoyau opened this issue 2 years ago • 7 comments

1.Add index.d.ts to the package.json's files. 2.change the index.d.ts , use any type. 3.change the python file , exclude index.d.ts

vihoyau avatar Sep 01 '22 09:09 vihoyau

Please correct the title of PR to match your code change.

wu-sheng avatar Sep 01 '22 10:09 wu-sheng

my local "CI" is ok, why that dosen't effective

vihoyau avatar Sep 01 '22 10:09 vihoyau

CI shows,

  1. This header seems not expected, maybe wrong comment formart for ts file?
  2. Can't pass compiling in Node 16.x.

I am not a frontend developer, but these should not be an issue.

wu-sheng avatar Sep 01 '22 10:09 wu-sheng

You could check the CI logs on your own. You need to make sure versions of tools(skywalking-eyes) and npm/nodejs are consistent.

wu-sheng avatar Sep 01 '22 11:09 wu-sheng

my "node" version is v16.17.0 i use command "npm ci " 、"npm run build --if-present " 、"python3 tools/check-license-header.py ." 。 its ok image

vihoyau avatar Sep 02 '22 03:09 vihoyau

You could use your own fork repo, to trigger GitHub action. We can't know your local env.

wu-sheng avatar Sep 02 '22 03:09 wu-sheng

i fork repo anew , it‘s error when take a command "npm install " . because the webpack version. 12.xx is ok.

vihoyau avatar Sep 02 '22 06:09 vihoyau