singa icon indicating copy to clipboard operation
singa copied to clipboard

Fix some GitHub Actions

Open tinyAdapter opened this issue 1 year ago • 3 comments

Due to a bug in Ubuntu 22.04, package libgoogle-glog-dev cannot be installed, which fails the Action workflow.

As a temporary solution, the Ubuntu OS version in the workflow can be pinned to 20.04. For 22.04, the workflow may be modified to build glog from source.

Also, the license headers in some files are added/updated to comply with the text listed in ASF policy. The license-checking workflow should pass now.

tinyAdapter avatar Mar 25 '24 08:03 tinyAdapter

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.74%. Comparing base (05876f9) to head (bf5f6ed). Report is 219 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1153   +/-   ##
=======================================
  Coverage   60.74%   60.74%           
=======================================
  Files          85       85           
  Lines        4524     4524           
=======================================
  Hits         2748     2748           
  Misses       1776     1776           
Flag Coverage Δ
singa-cpp 60.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 25 '24 08:03 codecov[bot]

Hello tinyAdapter,

Thanks for your pull request!

Could you please send the pull request to dev-postgresql branch?

Also, could we keep in contact on these issues? You can send me an email via [email protected]

Thanks, Zhaojing.

lzjpaul avatar Mar 25 '24 08:03 lzjpaul

Due to a bug in Ubuntu 22.04, package libgoogle-glog-dev cannot be installed, which fails the Action workflow.

As a temporary solution, the Ubuntu OS version in the workflow can be pinned to 20.04. For 22.04, the workflow may be modified to build glog from source.

Also, the license headers in some files are added/updated to comply with the text listed in ASF policy. The license-checking workflow should pass now.

Due to a bug in Ubuntu 22.04, package libgoogle-glog-dev cannot be installed, which fails the Action workflow.

As a temporary solution, the Ubuntu OS version in the workflow can be pinned to 20.04. For 22.04, the workflow may be modified to build glog from source.

Also, the license headers in some files are added/updated to comply with the text listed in ASF policy. The license-checking workflow should pass now.

Hello tinyAdapter,

Thanks for your pull request!

Could you please send the pull request to dev-postgresql branch?

Also, could we keep in contact on these issues? You can send me an email via [email protected]

Thanks, Zhaojing.

lzjpaul avatar Mar 25 '24 08:03 lzjpaul

Seems the updated action has been reflected in the latest dev-postgresql branch. Closed.

tinyAdapter avatar Apr 25 '24 08:04 tinyAdapter