singa icon indicating copy to clipboard operation
singa copied to clipboard

SINGA-117 add a switch for enabling/disabling INFO-level logging

Open cac2003 opened this issue 9 years ago • 5 comments

add switch for enabling/disabling INFO-level logging

cac2003 avatar Dec 22 '15 08:12 cac2003

can we do it in this way?

in singa.h

namespace singa{
  external bool singa_verbose;
}

in main.cc

#include "singa.h"
...
if -verbose in argv
   singa_verbose = true 
else 
   singa_verbose = false

nudles avatar Dec 23 '15 04:12 nudles

@cac2003 I am going to merge this pull request. before that, pls clean the commit msgs following the format http://singa.apache.org/develop/contribute-code.html.

  1. the commit msg title should be SINGA-xxx aaaaaaaaaa
  2. squash small commits together using git rebase -i commit_id
  3. rebase to the latest master

nudles avatar Dec 27 '15 08:12 nudles

how to determine the xxx part of commit msg title?

cac2003 avatar Dec 28 '15 02:12 cac2003

Once you create the jira ticket you will see a ticket No., which is the xxx

Sent from my iPhone

On 28 Dec 2015, at 10:06 AM, CAI QINGCHAO [email protected] wrote:

how to determine the xxx part of commit msg title?

— Reply to this email directly or view it on GitHub.

nudles avatar Dec 28 '15 02:12 nudles

Could you pls unify the format of all key-value tuples in the log? E.g., key = value[, key = value] (or other format that is easy to read). It would be useful (easy) to parsing the log file to get all key-value tuples. Thanks.

nudles avatar Dec 30 '15 03:12 nudles