shiro icon indicating copy to clipboard operation
shiro copied to clipboard

[SHIRO-802] expect running ITs, create profile for ITs.

Open bmarwell opened this issue 4 years ago • 2 comments

Following this checklist to help us incorporate your contribution quickly and easily:

  • [X] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [X] Each commit in the pull request should have a meaningful subject line and body.
  • [X] Format the pull request title like [SHIRO-XXX] - Fixes bug in SessionManager, where you replace SHIRO-XXX with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [X] Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [X] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...). In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

bmarwell avatar Aug 01 '21 20:08 bmarwell

Some changes got lost.

  1. run-its missing in last checkbox
  2. wording will update later

bmarwell avatar Aug 02 '21 08:08 bmarwell

@bdemers @fpapon have you noticed that ITs will not run in the default profile anymore?

Yes, looks good to me.

fpapon avatar Aug 03 '21 08:08 fpapon