[Enhancement] Remove all "rawtypes"

[lprimak]

Search before asking

• [X] I had searched in the issues and found no similar issues.

Enhancement Request

Remove all "raw" types from the code and APIs

Describe the solution you'd like

N/A

Are you willing to submit PR?

• [X] Yes I am willing to submit a PR!

[lprimak]

See:

Absolutely! Here's a quick recipe run: https://app.moderne.io/results/j2iJu9Xxx/ And a branch you can use to create a PR to clear out those 152 cases. https://github.com/apache/shiro/compare/main...timtebeek:shiro:refactor/use-diamond-operator?expand=1

[Luis-EncoraDev]

Hello, do you still need help with this issue? Could I get it assigned to me?

[lprimak]

Sure, here you go, and thank you

[Luis-EncoraDev]

@lprimak Should I use the refactor/use-diamon-operator branch to implement the changes or rather create another one?

[lprimak]

Not sure what you mean. I don't see any such branches.

[bmarwell]

@Luis-EncoraDev: You do not have such a branch: https://github.com/Luis-EncoraDev/shiro/branches

[Luis-EncoraDev]

My bad then, thanks!

[Luis-EncoraDev]

I've been trying to replace all rawtypes during these last days, but when I ran ./mvnw verify I would get some errors pointing to a specific folder, I would undo the changes causing the error and then pass to the next files. However, at some point I could not get back to a successful building of the app, even though I deleted the project and started over a fresh fork again, even without any changes to the codebase I keep on getting a BUILD FAILURE. Do you have any hints on how this could be solved?

[lprimak]

Can you paste full error log please? The actual error is missing from the screenshots. Please attach a log file, screenshots are not useful. Thank you!

[Luis-EncoraDev]

Sure,apparently it has something to do with the Apache RAT plugin.

shiro_mvn_verify.log

[lprimak]

Just move the log file out of your Shiro build directory. The log itself is causing the issue.

[bmarwell]

@Luis-EncoraDev do you want to work on this?

[Luis-EncoraDev]

Hi, I came across with the error described above and couldn't really find a workaround, so I'm no longer working on this.

[lprimak]

• You don't need to run ./mvnw verify just mvn package would suffice.
• or run mvn verify -DskipITs or mvn -fn (fail-never)

You don't really need to run integration tests for this task to work. Have you tried that?

[Luis-EncoraDev]

Ooh, no, I didn't try that. But I don't think I will be able to work on this anymore.

[bmarwell]

Do we have a branch?

[Luis-EncoraDev]

Nope, I didn't create any.