shenyu icon indicating copy to clipboard operation
shenyu copied to clipboard
verified publisher icon apache

[BUG] In the divide plugin, when setting the upstream service to "open" and then closing and reopening it, it will display as a number.

Open AbelKeithsun opened this issue 9 months ago • 8 comments

Is there an existing issue for this?

  • [x] I have searched the existing issues

Current Behavior

In the divide plugin, when setting the upstream service to "open" and then closing and reopening it, it will display as a number.

Image

Expected Behavior

Expecting to display as characters, such as close/open or 启用/禁用 (enabled/disabled)

Steps To Reproduce

No response

Environment

ShenYu version(s):2.7.0

Debug logs

No response

Anything else?

No response

AbelKeithsun avatar Mar 28 '25 07:03 AbelKeithsun

should modify: https://github.com/apache/shenyu-dashboard

Aias00 avatar Mar 28 '25 11:03 Aias00

I'd like to take up this bug. Can you please assign it to me?

azgartaj avatar Mar 29 '25 10:03 azgartaj

@Aias00 , I've made the change and tested it. I'm not expert in frontend, so please let me know if the approach looks good. I can explore alternate implementation otherwise.

azgartaj avatar Mar 30 '25 18:03 azgartaj

Hi @Aias00 , following up on this issue. It seems @azgartaj might be busy as there hasn't been activity on PR #526 for a while, and I haven't heard back. I'm still very interested in tackling this 'good first issue' if it's available. What would be the best way to proceed? Should I wait longer, or would it be okay for me to pick this up?"

fantasy-lotus avatar May 09 '25 05:05 fantasy-lotus

Hi @Aias00 , following up on this issue. It seems @azgartaj might be busy as there hasn't been activity on PR #526 for a while, and I haven't heard back. I'm still very interested in tackling this 'good first issue' if it's available. What would be the best way to proceed? Should I wait longer, or would it be okay for me to pick this up?"

hi, We're very happy you're interested in contributing.

Aias00 avatar May 09 '25 06:05 Aias00

hi, We're very happy you're interested in contributing.

I've done my work and tested it successfully, now i create an PR. Hoping for reviewed when you have time😊

fantasy-lotus avatar May 09 '25 08:05 fantasy-lotus

hi, We're very happy you're interested in contributing.

I've done my work and tested it successfully, now i create an PR. Hoping for reviewed when you have time😊

add your pr link, pls

Aias00 avatar May 09 '25 08:05 Aias00

hi, We're very happy you're interested in contributing.

I've done my work and tested it successfully, now i create an PR. Hoping for reviewed when you have time😊

add your pr link, pls

https://github.com/apache/shenyu-dashboard/pull/529

fantasy-lotus avatar May 09 '25 08:05 fantasy-lotus