shenyu icon indicating copy to clipboard operation
shenyu copied to clipboard

[Task] refactor provider client sdks

Open loongs-zhang opened this issue 2 years ago • 7 comments

Description

Now there are some duplicate codes in the client SDK. This issue aim to solve the problem.

There are some useful information in https://github.com/apache/shenyu/pull/3935 and https://github.com/apache/shenyu/pull/3931 .

Task List

    • [x] refactor shenyu-client-alibaba-dubbo; @847850277
    • [ ] refactor shenyu-client-grpc; @totalo
    • [ ] refactor shenyu-client-springcloud; @Albertsirius
    • [ ] refactor shenyu-client-motan; @misaya295
    • [ ] refactor shenyu-client-sofa; @zjcscut
    • [x] refactor shenyu-client-tars; @yunlongn
    • [ ] refactor shenyu-client-websocket; @lahmXu

loongs-zhang avatar Sep 11 '22 01:09 loongs-zhang

pls asign task 1 to me. thanks

847850277 avatar Sep 11 '22 07:09 847850277

pls asign task 2 to me. thanks

totalo avatar Sep 11 '22 09:09 totalo

pls assign task 3 to me. Thx

Albertsirius avatar Sep 11 '22 13:09 Albertsirius

Please assign task 7 to me, thanks!

lahmXu avatar Sep 12 '22 04:09 lahmXu

pls asign task 5 to me. Thx

zjcscut avatar Sep 13 '22 02:09 zjcscut

Please assign task 6 to me, thanks!

yunlongn avatar Sep 13 '22 07:09 yunlongn

pls asign task 4 to me. Thx

misaya295 avatar Sep 13 '22 08:09 misaya295

@dragon-zhang Hi, I found the appName assigned different value when refactoring shenyu-client-springcloud: In the original constructor of SpringCloudClientEventListener: Screen Shot 2022-09-25 at 21 36 54

But in the constructor of AbstractContextRefreshedEventListener: Screen Shot 2022-09-25 at 21 38 25

Should I keep the original or use the superclass assignment?

Albertsirius avatar Sep 25 '22 13:09 Albertsirius

@dragon-zhang Hi, I found the appName assigned different value when refactoring shenyu-client-springcloud: In the original constructor of SpringCloudClientEventListener: Screen Shot 2022-09-25 at 21 36 54

But in the constructor of AbstractContextRefreshedEventListener: Screen Shot 2022-09-25 at 21 38 25

Should I keep the original or use the superclass assignment?

keep the original, and you need to override getAppName.

loongs-zhang avatar Sep 26 '22 09:09 loongs-zhang

Good job, guys !

loongs-zhang avatar Sep 27 '22 13:09 loongs-zhang