shenyu
shenyu copied to clipboard
[Task] refactor provider client sdks
Description
Now there are some duplicate codes in the client SDK. This issue aim to solve the problem.
There are some useful information in https://github.com/apache/shenyu/pull/3935 and https://github.com/apache/shenyu/pull/3931 .
Task List
-
- [x] refactor shenyu-client-alibaba-dubbo; @847850277
-
- [ ] refactor shenyu-client-grpc; @totalo
-
- [ ] refactor shenyu-client-springcloud; @Albertsirius
-
- [ ] refactor shenyu-client-motan; @misaya295
-
- [ ] refactor shenyu-client-sofa; @zjcscut
-
- [x] refactor shenyu-client-tars; @yunlongn
-
- [ ] refactor shenyu-client-websocket; @lahmXu
pls asign task 1 to me. thanks
pls asign task 2 to me. thanks
pls assign task 3 to me. Thx
Please assign task 7 to me, thanks!
pls asign task 5 to me. Thx
Please assign task 6 to me, thanks!
pls asign task 4 to me. Thx
@dragon-zhang Hi, I found the appName
assigned different value when refactoring shenyu-client-springcloud
:
In the original constructor of SpringCloudClientEventListener
:
But in the constructor of AbstractContextRefreshedEventListener
:
Should I keep the original or use the superclass assignment?
@dragon-zhang Hi, I found the
appName
assigned different value when refactoringshenyu-client-springcloud
: In the original constructor ofSpringCloudClientEventListener
:But in the constructor of
AbstractContextRefreshedEventListener
:Should I keep the original or use the superclass assignment?
keep the original, and you need to override getAppName
.
Good job, guys !