shenyu icon indicating copy to clipboard operation
shenyu copied to clipboard

[Volunteer] Improve unit test coverage of shenyu-common

Open JooKS-me opened this issue 2 years ago • 13 comments

Volunteer help

As a branch of #3274 .

At present, the test coverage of shenyu-common module is not high. Please try to make the test coverage of each class reach more than 80% (in the case of ensuring the stability of the test).

If you would like to help, please leave a message under this issue. BTW, you can use Run 'Test in 'xxx'' With Coverage in IntelliJ IDEA to see the approximate coverage. image

PS: If the modified code is too much, it can be divided into several pr submissions.

  • [x] org.apache.shenyu.common.cache @selectbook
  • [x] org.apache.shenyu.common.concurrent @Albertsirius
  • [x] org.apache.shenyu.common.config @Nick-fengzl
  • [x] org.apache.shenyu.common.dto @luoweijr
  • [ ] org.apache.shenyu.common.timer @jun0315
  • [ ] org.apache.shenyu.common.utils (maybe a large job) @zhangcly

JooKS-me avatar Apr 18 '22 14:04 JooKS-me

@JooKS-me Hi, I would like to participate in this and pick the package of org.apache.shenyu.common.cache

selectbook avatar Apr 18 '22 14:04 selectbook

@JooKS-me Hello, I would like to participate in this task. Can you assign the package of org.apache.shenyu.common.concurrent to me ?

Albertsirius avatar Apr 18 '22 23:04 Albertsirius

@JooKS-me Hello, I would like to participate in this task. Can you assign the package of org.apache.shenyu.common.concurrent to me ?

Good luck

JooKS-me avatar Apr 19 '22 02:04 JooKS-me

@JooKS-me Hello, I would like to hava a try and pick the package of org.apache.shenyu.common.dto

luoweijr avatar Apr 19 '22 13:04 luoweijr

@JooKS-me Hi, I would like to participate in this and pick the package of org.apache.shenyu.common.timer

jun0315 avatar Apr 21 '22 06:04 jun0315

@JooKS-me Hello, I would like to participate in this task. Can you assign the package of org.apache.shenyu.common.config to me ?

Nick-fengzl avatar Apr 22 '22 03:04 Nick-fengzl

@JooKS-me can you assigin org.apache.shenyu.common.utils to me? thanks

zhangcly avatar Apr 22 '22 03:04 zhangcly

@Nick-fengzl @zhangcly OK :)

JooKS-me avatar Apr 22 '22 03:04 JooKS-me

@JooKS-me @selectbook Hi, I see org.apache.shenyu.common.cache is no complete, can I take this task?

MichaelDeSteven avatar May 22 '22 16:05 MichaelDeSteven

@JooKS-me @selectbook Hi, I see org.apache.shenyu.common.cache is no complete, can I take this task?

@MichaelDeSteven Hi, I found the cache package unnecessary to enhance the test. You can find small packages that need to improve test coverage in https://app.codecov.io/gh/apache/incubator-shenyu, and then create an issue to indicate what you want to do. Generally, we need to increase the test coverage to 80%.

BTW, ping @jun0315 @zhangcly, are you still doing it?

JooKS-me avatar May 22 '22 17:05 JooKS-me

@JooKS-me @selectbook Hi, I see org.apache.shenyu.common.cache is no complete, can I take this task?

@MichaelDeSteven Hi, I found the cache package unnecessary to enhance the test. You can find small packages that need to improve test coverage in https://app.codecov.io/gh/apache/incubator-shenyu, and then create an issue to indicate what you want to do. Generally, we need to increase the test coverage to 80%.

BTW, ping @jun0315 @zhangcly, are you still doing it?

Sorry, I find it a little difficult. Please assign this task to others.

jun0315 avatar May 28 '22 13:05 jun0315

@JooKS-me @selectbook Hi, I see org.apache.shenyu.common.cache is no complete, can I take this task?

@MichaelDeSteven Hi, I found the cache package unnecessary to enhance the test. You can find small packages that need to improve test coverage in https://app.codecov.io/gh/apache/incubator-shenyu, and then create an issue to indicate what you want to do. Generally, we need to increase the test coverage to 80%. BTW, ping @jun0315 @zhangcly, are you still doing it?

Sorry, I find it a little difficult. Please assign this task to others.

@JooKS-me I will try to finish the task of org.apache.shenyu.common.timer

selectbook avatar May 28 '22 14:05 selectbook

@JooKS-me I will try to finish the task of org.apache.shenyu.common.timer

Thanks and good luck!

JooKS-me avatar May 28 '22 14:05 JooKS-me

Hello, I would like to participate in this task. Can you assign the package of org.apache.shenyu.common.utils.ReflectUtils to me

xcsnx avatar Nov 24 '22 08:11 xcsnx