shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard

Add Doris grammar rules for RECOVER and tests

Open shamilv opened this issue 1 year ago • 5 comments

Fixes #31504 .

Changes proposed in this pull request:

  • Added changes necessary to parse Doris RECOVER statements including:
    • RECOVER PARTITION
    • RECOVER DATABASE
    • RECOVER TABLE
  • Added tests

Before committing this PR, I'm sure that I have checked the following options:

  • [x] My code follows the code of conduct of this project.
  • [x] I have self-reviewed the commit code.
  • [x] I have (or in comment I request) added corresponding labels for the pull request.
  • [x] I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • [ ] I have made corresponding changes to the documentation.
  • [x] I have added corresponding unit tests for my changes.

shamilv avatar Oct 28 '24 06:10 shamilv

https://shardingsphere.apache.org/community/en/involved/conduct/code/#maintenance-conduct @shamilv Could you please verify if MySQL supports these? You can refer to this document for further information.

Additionally, please update the release notes for 5.5.2-SNAPSHOT.

iamhucong avatar Oct 31 '24 01:10 iamhucong

Hi @shamilv, can you take a look for @iamhucong suggestion?

strongduanmu avatar Dec 11 '24 05:12 strongduanmu

Hi @strongduanmu Sure. I'll push the changes this weekend.

shamilv avatar Dec 11 '24 05:12 shamilv

https://shardingsphere.apache.org/community/en/involved/conduct/code/#maintenance-conduct @shamilv Could you please verify if MySQL supports these? You can refer to this document for further information.

Additionally, please update the release notes for 5.5.2-SNAPSHOT.

@iamhucong MySQL doesn't have a RECOVER SQL statement. Release notes are updated

shamilv avatar Dec 26 '24 17:12 shamilv

Hi @iamhucong / @strongduanmu Please review the changes

shamilv avatar Dec 26 '24 18:12 shamilv