shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard
verified publisher icon apache

Verified parsing for MySQL methods

Open ganesh-vk opened this issue 1 year ago • 2 comments

Fixes #31556 .

Changes proposed in this pull request: -Verified parsing of MySQL methods and added corresponding tests:

Before committing this PR, I'm sure that I have checked the following options:

  • [x] My code follows the code of conduct of this project.
  • [x] I have self-reviewed the commit code.
  • [ ] I have (or in comment I request) added corresponding labels for the pull request.
  • [x] I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] I have added corresponding unit tests for my changes.

ganesh-vk avatar Oct 16 '24 22:10 ganesh-vk

Hi @terrymanu, Could you please review these changes. The build is passing locally, including the shardingsphere-parser-sql-mysql module. I have attached screenshots for the same. image image

ganesh-vk avatar Oct 17 '24 08:10 ganesh-vk

Hi, Could I get an update on this? The parser parsed all these queries without any errors hence no changes to the grammar file was required. Please let me know if any changes are required.

ganesh-vk avatar Oct 20 '24 19:10 ganesh-vk