shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard

Proxy Dockerfile uses the obsolete `MAINTAINER` tag and Legacy Key Value Format

Open linghengqian opened this issue 5 months ago • 0 comments

Feature Request

For English only, other languages will not be accepted.

Please pay attention on issues you submitted, because we maybe need more details. If no response anymore and we cannot make decision by current information, we will close it.

Please answer these questions before submitting your issue. Thanks!

Is your feature request related to a problem?

  • No.

Describe the feature you would like.

  • Proxy Dockerfile uses the obsolete MAINTAINER tag and Legacy Key Value Format. Refer to https://docs.docker.com/reference/build-checks/maintainer-deprecated/ and https://docs.docker.com/reference/build-checks/legacy-key-value-format/ .
  • See
    • https://github.com/apache/shardingsphere/blob/master/distribution/proxy/Dockerfile
    • https://github.com/apache/shardingsphere/blob/master/distribution/proxy-native/Dockerfile
  • I think for the following tags,
MAINTAINER ShardingSphere "[email protected]"
  • should be replaced with something like https://gitlab.com/gitlab-org/omnibus-gitlab/-/commit/94105c86fbb266a7e45f7b9c7eebac066ca2a7be ,
LABEL org.opencontainers.image.authors="ShardingSphere [email protected]"
  • For statements like the following,
ENV LOCAL_PATH /opt/shardingsphere-proxy
  • Should be replaced by,
ENV LOCAL_PATH=/opt/shardingsphere-proxy

linghengqian avatar Aug 25 '24 02:08 linghengqian