shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard

[code conduct] There are a lot of indents in the g4 files that shouldn't be there

Open RaigorJiang opened this issue 1 year ago • 4 comments

According to Parser Conduct, blank line should have no indents https://shardingsphere.apache.org/community/en/involved/conduct/code/#contributor-covenant-g4-of-conduct

shardingsphere-parser-sql-mysql

image

shardingsphere-parser-sql-hive

image

RaigorJiang avatar Jun 27 '24 06:06 RaigorJiang

@RaigorJiang I will finish it.

elysium-w avatar Jun 27 '24 18:06 elysium-w

Assigned, thank you @elysium-w

RaigorJiang avatar Jun 28 '24 10:06 RaigorJiang

Assigned, thank you @elysium-w

which branch should I submit this work to?

elysium-w avatar Jun 28 '24 13:06 elysium-w

@elysium-w Please submit a PR for master, thank you! https://shardingsphere.apache.org/community/en/involved/contribute/contributor/

RaigorJiang avatar Jun 29 '24 16:06 RaigorJiang