shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard

YamlDatabaseConfigurationImportExecutor should be decoupled from feature

Open RaigorJiang opened this issue 1 year ago • 3 comments

YamlDatabaseConfigurationImportExecutor is used to implement the rule import function for ImportDatabaseConfigurationExecutor.

But now YamlDatabaseConfigurationImportExecutor relies heavily on various features. In fact, it should use SPI to manage rules like ExportDatabaseConfigurationExecutor to achieve decoupling.

We can refer to ExportDatabaseConfigurationExecutor and ConvertYamlConfigurationExecutor.

RaigorJiang avatar Feb 19 '24 02:02 RaigorJiang

Hi @RaigorJiang , I want to try.

yx9o avatar Feb 19 '24 11:02 yx9o

@yx9o Hi, the 5.5.0 version will be released next week. Can it be completed during this period?

zhaojinchao95 avatar Feb 23 '24 10:02 zhaojinchao95

@yx9o Hi, the 5.5.0 version will be released next week. Can it be completed during this period?

Can it be moved to the next milestone?

yx9o avatar Feb 23 '24 11:02 yx9o

No milestone has been set for this issue 😀

RaigorJiang avatar Feb 24 '24 02:02 RaigorJiang

Completed, thank you! @yx9o

RaigorJiang avatar Mar 15 '24 03:03 RaigorJiang