shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard

Consider formatting algorithm props output to JSON

Open Pace2Car opened this issue 2 years ago • 2 comments

Query rules through RQL or RAL, and the format of algorithm props in the results obtained is as follows:

+-------------------------------------------------------+
| encryptor_props                                       |
+-------------------------------------------------------+
| aes-key-value=BA,FF=AB3,digest-algorithm-name=SHA-512 |
+-------------------------------------------------------+

The problem is that if the parameter value contains characters such as "=", "," etc., it may cause misunderstanding.

Using JSON format eliminates misunderstandings

+-----------------------------------------------------------------+
| encryptor_props                                                 |
+-----------------------------------------------------------------+
| {"aes-key-value"="BA,FF=AB3","digest-algorithm-name"="SHA-512"} |
+-----------------------------------------------------------------+

I'm going to replace the output of algorithm props into JSON format, which will involve the following RQL and RAL implementation changes

TASK LIST:

  • [x] Refactor PropertiesConverter
  • [x] Unit tests
  • [x] E2E
  • [ ] Documention

Pace2Car avatar Nov 15 '23 09:11 Pace2Car

Good idea 👍

RaigorJiang avatar Nov 15 '23 09:11 RaigorJiang

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

github-actions[bot] avatar Dec 21 '23 20:12 github-actions[bot]