shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard

Add more unit tests for ExpressionSegmentBinder

Open tuichenchuxin opened this issue 1 year ago • 13 comments

Hi community,

This issue is for https://github.com/apache/shardingsphere/discussions/28487.

Aim

Add more unit tests for ExpressionSegmentBinder to test its public functions to improve unit test coverage.

Unit test coverage can be viewed at: https://app.codecov.io/gh/apache/shardingsphere

Basic Qualifications

  • Java
  • Maven
  • Junit

tuichenchuxin avatar Sep 21 '23 11:09 tuichenchuxin

Hi @tuichenchuxin,

I would like to work on this. can you please assign this to me?

Thanks

Gowrishankar04 avatar Oct 13 '23 17:10 Gowrishankar04

@Gowrishankar04 Welcome, I just assign it to you.

strongduanmu avatar Oct 14 '23 01:10 strongduanmu

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

github-actions[bot] avatar Nov 13 '23 20:11 github-actions[bot]

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

github-actions[bot] avatar Jan 27 '24 20:01 github-actions[bot]

Hi, @strongduanmu I tried working on this issue but I am facing this error during the building

image

Divyansh200102 avatar Jan 31 '24 03:01 Divyansh200102

@Divyansh200102 You can try ./mvnw clean install -Prelease -Dmaven.javadoc.skip=true -Djacoco.skip=true -T 1C -Drat.skip=true -Dmaven.test.skip=true first. Since we need Antlr generates code for SQL parsing.

strongduanmu avatar Jan 31 '24 03:01 strongduanmu

Can you remove -Dmaven.javadoc.skip=true?

strongduanmu avatar Jan 31 '24 04:01 strongduanmu

./mvnw clean install -Prelease -Dmaven.javadoc.skip=true -Djacoco.skip=true -T 1C -Drat.skip=true -Dmaven.test.skip=true

@strongduanmu the build failure is still coming shall I raise an issue? image

image

Divyansh200102 avatar Jan 31 '24 04:01 Divyansh200102

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

github-actions[bot] avatar Mar 01 '24 20:03 github-actions[bot]

hello Sir, I would like to work on this issue Kindly assign me this issue also it is going to be my first opensource contribution so kindly guide me a little. Thank You.

SankarshanMishra avatar Apr 17 '24 20:04 SankarshanMishra

@Gowrishankar04 Welcome, I just assign this issue to you.

strongduanmu avatar Apr 17 '24 23:04 strongduanmu

This is my first time contributing to open source. I'm familiar with JUnit5 and creating fake repositories, as well as using data structures for test cases(Mockito).However, I'm unsure how to apply these skills in this specific context. Kindly provide me some guidance?

On Thu, 18 Apr 2024, 05:24 Zhengqiang Duan, @.***> wrote:

@Gowrishankar04 https://github.com/Gowrishankar04 Welcome, I just assign this issue to you.

— Reply to this email directly, view it on GitHub https://github.com/apache/shardingsphere/issues/28538#issuecomment-2062727063, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5WQPWWFJKHINLXG6ROYTUTY54DSLAVCNFSM6AAAAAA5BLQIRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRSG4ZDOMBWGM . You are receiving this because you were assigned.Message ID: @.***>

SankarshanMishra avatar Apr 19 '24 09:04 SankarshanMishra

Screenshot (575) I dont know why I am unable to find the java file when claerly the location of the file is this Kindly help me out here a little shardingsphere\infra\binder\src\main\java\org\apache\shardingsphere\infra\binder\segment\expression\ExpressionSegmentBinder.java Thank You

SankarshanMishra avatar Apr 20 '24 22:04 SankarshanMishra

@strongduanmu Pls assign to me.

AbnerHuang2 avatar Jul 09 '24 03:07 AbnerHuang2