shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard

Support parsing Oracle UPDATE sales['Spain', sql

Open FlyingZC opened this issue 2 years ago • 8 comments

Background

Hi community, This issue is for #26878.

ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). Currently, we are planning to enhance the support for Oracle SQL parsing in ShardingSphere.

More details: https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/

Task

This issue is to support more oracle sql parse, as follows:

UPDATE sales['Spain', 1999] = 3567.99,
UPSERT sales['Spain', 2001] = sales['Spain', 2000]+ sales['Spain', 1999]
UPDATE table1_tab SET column = expression
VALUES (NULL, 'Sales', 200, 1700)
        *
ERROR at line 4:
ORA-01400: cannot insert NULL into ("HR"."DEPARTMENTS"."DEPARTMENT_ID")
UPSERT ALL sales[ANY, ANY, 'z']= sales[CV(product),CV(time),'y']
UPDATE employees SET salary =      
   (SELECT salary FROM employees
   AS OF TIMESTAMP (SYSTIMESTAMP - INTERVAL '2' MINUTE)
   WHERE last_name = 'Chung')
   WHERE last_name = 'Chung';
1 row updated.

SELECT salary FROM employees
   WHERE last_name = 'Chung';

Process

  1. First confirm that this is a correct oracle sql syntax, if not please ignore;
  2. Compare SQL definitions in Oficial SQL Doc and ShardingSphere SQL Doc;
  3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
  4. Run mvn install the current_file_module;
  5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
  6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statment XML;
  7. Run SQLParserParameterizedTest to make sure no exceptions.

Relevant Skills

  1. Master JAVA language
  2. Have a basic understanding of Antlr g4 file
  3. Be familiar with Oracle SQLs

FlyingZC avatar Jul 13 '23 08:07 FlyingZC

I can work on this issue. Please assign it to me.

SwapnilPatil07 avatar Jul 15 '23 16:07 SwapnilPatil07

@SwapnilPatil07 Assigned, good luck for you.

strongduanmu avatar Jul 17 '23 00:07 strongduanmu

Added Case and Expected xml for below query.

UPDATE employees SET salary =      
   (SELECT salary FROM employees
   AS OF TIMESTAMP (SYSTIMESTAMP - INTERVAL '2' MINUTE)
   WHERE last_name = 'Chung')
   WHERE last_name = 'Chung';

Other queries are throwing errors so I did not make changes for them. Please let me know what oracle version I need to check these queries. Also, I am not sure which SQL Doc are referred in below comment. Can you please provide link ?

Compare SQL definitions in Oficial SQL Doc and ShardingSphere SQL Doc;
If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;

SwapnilPatil07 avatar Jul 26 '23 02:07 SwapnilPatil07

@SwapnilPatil07 You can verify the correctness of the sql syntax on oracle 11g. If it is incorrect, just leave a message on the issue and ignore the sql.

FlyingZC avatar Jul 26 '23 03:07 FlyingZC

Screenshot of queries with errors

image

SwapnilPatil07 avatar Jul 29 '23 05:07 SwapnilPatil07

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

github-actions[bot] avatar Aug 29 '23 20:08 github-actions[bot]

Hi @SwapnilPatil07, Is this issue finished?

strongduanmu avatar Sep 15 '23 07:09 strongduanmu

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

github-actions[bot] avatar Oct 29 '23 20:10 github-actions[bot]