shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard

why not support set Hikari poolName ?

Open fuwenbo2013 opened this issue 3 years ago • 7 comments

Feature Request

For English only, other languages will not accept.

Please pay attention on issues you submitted, because we maybe need more details. If no response anymore and we cannot make decision by current information, we will close it.

Please answer these questions before submitting your issue. Thanks!

Is your feature request related to a problem?

Describe the feature you would like.

fuwenbo2013 avatar Jan 11 '23 05:01 fuwenbo2013

image

fuwenbo2013 avatar Jan 11 '23 05:01 fuwenbo2013

the poolName was added in latest version

fuwenbo2013 avatar Jan 11 '23 05:01 fuwenbo2013

Hi, the poolName are suddenly, I think we needn't care it. May I ask what you need to do with it?

zhaojinchao95 avatar Jan 11 '23 05:01 zhaojinchao95

ShardingSphere has some scenarios for refreshing metadata, and the connection pool will also be rebuilt. By default, different poolNames will be generated at this time, but if the user specifies a poolName, two pools before and after may have the same name, which may confuse monitoring indicators.

RaigorJiang avatar Jan 11 '23 07:01 RaigorJiang

ShardingSphere has some scenarios for refreshing metadata, and the connection pool will also be rebuilt. By default, different poolNames will be generated at this time, but if the user specifies a poolName, two pools before and after may have the same name, which may confuse monitoring indicators.

If use the custome poolName as the prefix, can it be solved?

fuwenbo2013 avatar Jan 13 '23 03:01 fuwenbo2013

If use the custome poolName as the prefix, can it be solved?

So how to do with that, do you hava any idea?

RaigorJiang avatar Jan 13 '23 08:01 RaigorJiang

ShardingSphere has some scenarios for refreshing metadata, and the connection pool will also be rebuilt. By default, different poolNames will be generated at this time, but if the user specifies a poolName, two pools before and after may have the same name, which may confuse monitoring indicators.

If the user specifies duplicates, it is the user's problem Not currently supported. Let's take a look at the monitoring. How can we match the name of the connection pool with the specific data source?

jdxia avatar May 27 '24 09:05 jdxia

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

github-actions[bot] avatar Jul 21 '24 20:07 github-actions[bot]