shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard

Fix the integration problem of `Spring Boot Starter` and `SpringBoot OSS 3.0.0-M5`

Open linghengqian opened this issue 2 years ago • 3 comments

Fixes #20963.

Changes proposed in this pull request:

  • Fix the integration problem of Spring Boot Starter and SpringBoot OSS 3.0.0-M5.

Before committing this PR, I'm sure that I have checked the following options:

  • [x] My code follows the code of conduct of this project.
  • [x] I have self-reviewed the commit code.
  • [x] I have triggered maven check: mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e.
  • [x] I have made corresponding changes to the documentation.
  • [x] I have added corresponding unit tests for my changes.

linghengqian avatar Sep 18 '22 05:09 linghengqian

Codecov Report

Merging #21047 (c1ebcca) into master (ba081e0) will decrease coverage by 0.00%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #21047      +/-   ##
============================================
- Coverage     61.72%   61.71%   -0.01%     
  Complexity     2543     2543              
============================================
  Files          4069     4069              
  Lines         56173    56173              
  Branches       9471     7489    -1982     
============================================
- Hits          34670    34668       -2     
+ Misses        18610    18567      -43     
- Partials       2893     2938      +45     
Impacted Files Coverage Δ
...ntracing/service/OpenTracingPluginBootService.java 61.53% <0.00%> (-7.70%) :arrow_down:
...jaeger/service/JaegerTracingPluginBootService.java 61.11% <0.00%> (-5.56%) :arrow_down:
...ingsphere/agent/core/plugin/AgentPluginLoader.java 0.00% <0.00%> (ø)
...infra/datasource/state/DataSourceStateManager.java 10.86% <0.00%> (ø)
...kend/handler/transaction/TransactionXAHandler.java 0.00% <0.00%> (ø)
...n/interceptor/InstanceMethodAroundInterceptor.java 0.00% <0.00%> (ø)
...nterceptor/ClassStaticMethodAroundInterceptor.java 0.00% <0.00%> (ø)
...rceptor/InstanceMethodInterceptorArgsOverride.java 0.00% <0.00%> (ø)
.../admin/mysql/executor/MySQLSetCharsetExecutor.java 25.00% <0.00%> (ø)
...ptor/ClassStaticMethodInterceptorArgsOverride.java 0.00% <0.00%> (ø)
... and 19 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 18 '22 06:09 codecov-commenter

  • This PR is listed as a draft because I found that there are spring.factories that have not been processed.
  • Refer to https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.7-Release-Notes#changes-to-auto-configuration .

linghengqian avatar Sep 20 '22 17:09 linghengqian

CC @zhaojinchao95 .

linghengqian avatar Sep 22 '22 00:09 linghengqian

  • It looks like the website for Continuous Integration/ShardingSphere test coverage report is down, nothing to do with me.👀
  • image

linghengqian avatar Sep 24 '22 07:09 linghengqian