shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard

Published 20 hours ago • verified publisher icon apache

Documentation for ShardingSphere Agent may can simplify things

Open linghengqian opened this issue 3 years ago • 1 comments
trafficstars

Question

For English only, other languages will not accept.

Before asking a question, make sure you have:

Please pay attention on issues you submitted, because we maybe need more details. If no response anymore and we cannot reproduce it on current information, we will close it.

  • In https://shardingsphere.apache.org/document/5.2.0/en/user-manual/shardingsphere-proxy/observability/#usage-in-shardingsphere-proxy , it mentions that Configure the absolute path of shardingsphere-agent.jar to the start.sh startup script of shardingsphere proxy. is required.
  • As far as I understand, modifying start.sh is very tedious work, and javaagent can be configured in the environment variable JVM_OPTS. This should be similar to -javaagent /xxxxx/agent/shardingsphere-agent.jar. As mentioned in https://github.com/cloudfoundry/java-buildpack/issues/555#issuecomment-368583041, requires modification start.sh complicates things. Refer to https://shardingsphere.apache.org/document/5.2.0/en/user-manual/shardingsphere-proxy/startup/docker/ .
  • image

linghengqian avatar Sep 12 '22 08:09 linghengqian

Yes, modifying start.sh is a bit fiddly, especially in a container environment. We should consider a way to quickly control whether to start the agent or not.

RaigorJiang avatar Sep 17 '22 08:09 RaigorJiang

Hello , this issue has not received a reply for several days. This issue is supposed to be closed.

github-actions[bot] avatar Oct 08 '22 16:10 github-actions[bot]

  • How should I reopen this issue? I'm just waiting for one of my PRs to be merged...

linghengqian avatar Oct 08 '22 16:10 linghengqian

  • How should I reopen this issue? I'm just waiting for one of my PRs to be merged...

Hi @linghengqian , which PR is related to this issue?

RaigorJiang avatar Oct 09 '22 02:10 RaigorJiang

  • Actually I was talking about https://github.com/apache/shardingsphere/pull/21341 ,🤣 but due to recent changes in master branch, it had a merge conflict not long ago, which has now been resolved.
  • Since I don't really want to manage multiple PRs at the same time, I usually don't work on issues in parallel. For this current issue, I will submit a PR shortly.

linghengqian avatar Oct 09 '22 06:10 linghengqian