shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard

Enhanced algorithm checking for CREATE SHARDING TABLE RULE

Open sunkai-cai opened this issue 2 years ago • 1 comments

Fixes #20378.

Changes proposed in this pull request:

  • It must not use the Auto Sharding Algorithm In the tableRuleSegment

sunkai-cai avatar Sep 04 '22 15:09 sunkai-cai

Codecov Report

Merging #20777 (2e55e07) into master (dbac9a8) will increase coverage by 0.01%. The diff coverage is 89.28%.

@@             Coverage Diff              @@
##             master   #20777      +/-   ##
============================================
+ Coverage     61.63%   61.64%   +0.01%     
- Complexity     2475     2481       +6     
============================================
  Files          4064     4063       -1     
  Lines         55840    55857      +17     
  Branches       9457     9460       +3     
============================================
+ Hits          34416    34435      +19     
+ Misses        18550    18549       -1     
+ Partials       2874     2873       -1     
Impacted Files Coverage Δ
...ception/DataSourceJndiNotFoundServerException.java 0.00% <ø> (ø)
.../shardingsphere/spring/boot/util/PropertyUtil.java 35.93% <0.00%> (-1.16%) :arrow_down:
...ler/checker/ShardingTableRuleStatementChecker.java 86.09% <100.00%> (+1.35%) :arrow_up:
...re/spring/boot/datasource/DataSourceMapSetter.java 56.00% <0.00%> (+4.00%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 04 '22 16:09 codecov-commenter

Hi @sunkai-cai, can you solve code conflict?

strongduanmu avatar Oct 12 '22 00:10 strongduanmu

Hi @sunkai-cai This PR has not been active for a long time, and you may have to deal with many conflicts, I will close it now.

RaigorJiang avatar Oct 23 '22 14:10 RaigorJiang