shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard

Add more unit tests in the class of `TransactionRuleTest` for transactions

Open FlyingZC opened this issue 3 years ago • 1 comments

Hi community, This issue is for #20305

Aim

Add more unit tests in the class of org.apache.shardingsphere.transaction.rule.TransactionRuleTest.

Basic Qualifications

  • Java
  • Maven
  • Transaction

Detail

You can add more unit tests for the methods of addResource,closeStaleResource,closeStaleResource in the class. E.g. when you call addResource,it will recreate the ShardingSphereTransactionManagerEngine and the databases will contain the database you added.

FlyingZC avatar Aug 22 '22 03:08 FlyingZC

assign to me

huangdx0726 avatar Aug 23 '22 11:08 huangdx0726

Hello , this issue has not received a reply for several days. This issue is supposed to be closed.

github-actions[bot] avatar Oct 08 '22 16:10 github-actions[bot]

这是来自QQ邮箱的假期自动回复邮件。   您好,我最近正在休假中,无法亲自回复您的邮件。我将在假期结束后,尽快给您回复。

huangdx0726 avatar Oct 08 '22 16:10 huangdx0726

Fixed by #22165.

FlyingZC avatar May 22 '23 04:05 FlyingZC

这是来自QQ邮箱的假期自动回复邮件。   您好,我最近正在休假中,无法亲自回复您的邮件。我将在假期结束后,尽快给您回复。

huangdx0726 avatar May 22 '23 04:05 huangdx0726