shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard

Published 20 hours ago • verified publisher icon apache

Enhance startup script

Open sunkai-cai opened this issue 1 year ago • 2 comments

Fixes #15663.

Changes proposed in this pull request:

  • Refactor the script
  • Priority use java from JAVA_HOME
  • Check a tcp IP:Port is can be use
  • Judge startup succeeded or failed

sunkai-cai avatar Aug 09 '22 15:08 sunkai-cai

How about echoing some warning instead of exiting if addresses & port checking failed? I'm not sure whether the checking could cover all cases.

TeslaCN avatar Aug 11 '22 02:08 TeslaCN

How about echoing some warning instead of exiting if addresses & port checking failed? I'm not sure whether the checking could cover all cases.

this a good idea.

sunkai-cai avatar Aug 11 '22 02:08 sunkai-cai

thanks @TeslaCN ，This is a good case。 I fix it to support mulit-ip for start.sh

sunkai-cai avatar Aug 11 '22 14:08 sunkai-cai

There are many cases should be considered in address and port checking. Maybe we could do the checking in next PR. This PR just focus on enhancements about Docker and JAVA_HOME.

TeslaCN avatar Aug 15 '22 02:08 TeslaCN