shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard

Published 20 hours ago • verified publisher icon apache

Add test cases for JDBCRepository

Open terrymanu opened this issue 1 year ago • 2 comments

  • [ ] Add fixture: JDBCRepositoryFixture implements JDBCRepository
  • [ ] Add test case with mock

terrymanu avatar Aug 05 '22 14:08 terrymanu

I can do this task

shining-stars-lk avatar Aug 06 '22 02:08 shining-stars-lk

@shining-stars-lk Welcome

magestacks avatar Aug 06 '22 02:08 magestacks

Hi @shining-stars-lk , could we finish this issue in 5.1.3?

strongduanmu avatar Aug 23 '22 11:08 strongduanmu

I will move this issue to 5.2.1.

strongduanmu avatar Aug 26 '22 02:08 strongduanmu

Hi @terrymanu Since there was no update on this issue since quite some time, I have taken a stab at it. I have created a PR https://github.com/apache/shardingsphere/pull/20699. Can you please review?

abhinav-koppula avatar Aug 31 '22 16:08 abhinav-koppula

@abhinav-koppula Please wait to run CI

magestacks avatar Sep 01 '22 01:09 magestacks

@agentart - Can you please assign the issue to me since the PR has been merged?

abhinav-koppula avatar Sep 02 '22 04:09 abhinav-koppula