shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard

Published 20 hours ago • verified publisher icon apache

Add test case for MetaDataContextsFactory

Open terrymanu opened this issue 2 years ago • 1 comments

terrymanu avatar Jul 16 '22 06:07 terrymanu

Can I try this issue?

mayank-aggarwal28 avatar Jul 16 '22 18:07 mayank-aggarwal28

Hi @mayank-aggarwal28 , could we finish this issue in 5.1.3?

strongduanmu avatar Aug 23 '22 11:08 strongduanmu

I will move this issue to 5.2.1.

strongduanmu avatar Aug 26 '22 02:08 strongduanmu

Hi @terrymanu
Since the issue hasn't been worked upon since quite some time, I have taken a stab at it. I have created PR - https://github.com/apache/shardingsphere/pull/20676. Can you please review it?

abhinav-koppula avatar Aug 31 '22 08:08 abhinav-koppula

The issue has not finished, we need to assert the created meta data too. I have already add todo during #20773

terrymanu avatar Sep 04 '22 13:09 terrymanu

The issue has not finished, we need to assert the created meta data too. I have already add todo during #20773

@terrymanu - I have created a new PR - https://github.com/apache/shardingsphere/pull/20778. I have mocked the static methods GlobalRulesBuilder.buildRules, ShardingSphereDatabasesFactory.create and have added assertions for the metadata.

abhinav-koppula avatar Sep 04 '22 19:09 abhinav-koppula