shardingsphere icon indicating copy to clipboard operation
shardingsphere copied to clipboard

Published 20 hours ago • verified publisher icon apache

[Issue#17635] Support oracle sql Procedure

Open kaori-seasons opened this issue 2 years ago • 6 comments

Fixes #ISSUSE_17635.

add oracle sql Procedure grammar Changes proposed in this pull request:

  • [ ] alterProcedure

  • [ ] createProcedure

  • [ ] dropProcedure

kaori-seasons avatar Jun 07 '22 13:06 kaori-seasons

Syntax errors need to be fixed at the moment, processing

kaori-seasons avatar Jun 07 '22 22:06 kaori-seasons

Hi @complone, maybe you should return OracleCreateProceduretStatement in method visitCreateProcedure, class OracleDDLStatementSQLVisitor.java

chakkk309 avatar Jun 13 '22 11:06 chakkk309

Hi @complone, maybe you should return OracleCreateProceduretStatement in method visitCreateProcedure, class OracleDDLStatementSQLVisitor.java

@chakkk309 The problem is that the syntax of Procedure needs to support begin...end content when creating So need to define additional keywords and expressions, I will refer to here https://github.com/antlr/grammars-v4/blob/master/sql/plsql/PlSqlParser.g4

kaori-seasons avatar Jun 19 '22 04:06 kaori-seasons

Hi @complone, can you resolve the conflict first? Otherwise, the ci test won't start.

chakkk309 avatar Jul 20 '22 14:07 chakkk309

Hi @complone, can you resolve the conflict first? Otherwise, the ci test won't start.

The grammar is still under development

kaori-seasons avatar Jul 21 '22 14:07 kaori-seasons

@complone The progress of this PR has not been upgraded for a long time. If there is no update, I will close it soon.

terrymanu avatar Aug 07 '22 16:08 terrymanu

I just close this PR and reopen issue #17635.

terrymanu avatar Aug 12 '22 04:08 terrymanu