sedona icon indicating copy to clipboard operation
sedona copied to clipboard

Feat/remove flink scala deps

Open Subham-KRLX opened this issue 1 month ago • 4 comments

Did you read the Contributor Guide?

Is this PR related to a ticket?

  • Yes, and the PR name follows the format [GH-2457] Remove Flink Scala dependency. Closes #2457

What changes were proposed in this PR?

According to Flink FLIP 265, the Flink community has decided to drop Scala API. Flink now also offers pure Java dependencies. This PR removes Flink Scala dependencies from Sedona to align with this change.

Key changes:

  • Modified flink/pom.xml:
    • Changed artifactId from sedona-flink_${scala.compat.version} to sedona-flink.
    • Replaced flink-table-planner_${scala.compat.version} with flink-table-planner-loader.
    • Removed scala-library dependency.
  • Updated flink-shaded/pom.xml to depend on the new sedona-flink artifact.

How was this patch tested?

  • Verified the build with mvn clean install -pl flink -am.
  • Ran tests with mvn test -pl flink -am.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

Subham-KRLX avatar Nov 22 '25 15:11 Subham-KRLX

@jiayuasu ,@jbampton please check this out.

Subham-KRLX avatar Nov 22 '25 17:11 Subham-KRLX

@jiayuasu ,@jbampton please check this out.

You opened the PR 4 days ago and then on the same day you send another message tagging two committers.

Please don't send this extra message straight away. We are "watching" the Sedona repo and we do get notifications of all PRs and issues opened.

There are many PRs and issues in play please try to be more patient.

For an example on CPython there are over 2k PRs and over 1k PRs awaiting review:

https://github.com/python/cpython/pulls?q=is%3Apr+is%3Aopen+label%3A%22awaiting+review%22

jbampton avatar Nov 26 '25 08:11 jbampton

Thanks for letting me know.Understood I’ll wait patiently and won’t send another ping so soon.

Subham-KRLX avatar Nov 26 '25 08:11 Subham-KRLX

this PR does not solve the issue. I don't think you actually understand it and this is harder than you think. Please don't work on this issue.

jiayuasu avatar Nov 26 '25 08:11 jiayuasu