sedona icon indicating copy to clipboard operation
sedona copied to clipboard

Standardize the pre-commit config by adding `name` and `description` keys/values to all hooks

Open jbampton opened this issue 6 months ago • 4 comments

https://github.com/apache/sedona/blob/master/.pre-commit-config.yaml

Having names and descriptions also helps with documenting the hooks and for quick reference.

We have names and descriptions on some hooks so we should be consistent and add them to all hooks.

jbampton avatar Jun 20 '25 17:06 jbampton

Hi @jbampton, I can work on this. Can you assign this to me?

SumitGupta016 avatar Jun 20 '25 22:06 SumitGupta016

Hey @SumitGupta016 you are now assigned

jbampton avatar Jun 21 '25 08:06 jbampton

Hey @SumitGupta016 you are now assigned

Roger!

SumitGupta016 avatar Jun 21 '25 08:06 SumitGupta016

@jbampton i opened a PR regarding this issue : https://github.com/apache/sedona/pull/1999

can you take a look on it and check if it helps with the issue, with my understanding this should close this issue.

SumitGupta016 avatar Jun 21 '25 08:06 SumitGupta016

@SumitGupta016 some of the hooks are still missing "name" and "description"

https://github.com/apache/sedona/blob/master/.pre-commit-config.yaml

jbampton avatar Jun 30 '25 12:06 jbampton

@SumitGupta016 some of the hooks are still missing "name" and "description"

https://github.com/apache/sedona/blob/master/.pre-commit-config.yaml

I'll check after my working hours, will that work?

SumitGupta016 avatar Jun 30 '25 14:06 SumitGupta016

@SumitGupta016 some of the hooks are still missing "name" and "description" https://github.com/apache/sedona/blob/master/.pre-commit-config.yaml

I'll check after my working hours, will that work?

Yes that is fine. No rush on this task

jbampton avatar Jun 30 '25 17:06 jbampton

Hey @SumitGupta016 we have not heard from you for a few months so I finished the remaining tasks in #2411

Thanks for your work. Closing now.

jbampton avatar Oct 23 '25 21:10 jbampton