sedona icon indicating copy to clipboard operation
sedona copied to clipboard

[GH-1996]Create object of S2Geography, and implement PoinGeography with its en…

Open ZhuochengShang opened this issue 6 months ago • 4 comments

…coder/decoder

Did you read the Contributor Guide?

Is this PR related to a ticket?

  • Yes, and the PR name follows the format [SEDONA-XXX] my subject.

  • Yes, and the PR name follows the format [GH-XXX] my subject.

  • No:

    • this is a documentation update. The PR name follows the format [DOCS] my subject
    • this is a CI update. The PR name follows the format [CI] my subject

What changes were proposed in this PR?

How was this patch tested?

Did this PR include necessary documentation updates?

  • Yes, I am adding a new API. I am using the current SNAPSHOT version number in vX.Y.Z format.
  • Yes, I have updated the documentation.
  • No, this PR does not affect any public API so no need to change the documentation.

ZhuochengShang avatar Jun 20 '25 16:06 ZhuochengShang

@ZhuochengShang great work. Please create a GitHub issue and link the PR to that issue using [GH-XXXX]

jiayuasu avatar Jun 20 '25 16:06 jiayuasu

Great work @ZhuochengShang . It is great to have a working PR that shows the progress. But when it is ready, we'd like to break it into a sequence of small PRs. This will make the review process easier.

jiayuasu avatar Jun 20 '25 23:06 jiayuasu

Please also update the title of this PR to [GH-XXXX] that links to the GitHub issue.

jiayuasu avatar Jun 20 '25 23:06 jiayuasu

Thank you for this work so far! Just a note that if you (or Kristin or Jia) run across anything that doesn't make sense or is sub-optimial in the C++ version of S2Geography to let me know!

paleolimbot avatar Jun 23 '25 15:06 paleolimbot

What is the status of this PR?

jiayuasu avatar Jun 30 '25 18:06 jiayuasu

Awesome!

paleolimbot avatar Jul 01 '25 15:07 paleolimbot